Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esbenp.prettier-vscode isn't consistent with prettier in package.json #3438

Open
6 tasks done
hamirmahal opened this issue Jun 19, 2024 · 1 comment
Open
6 tasks done

Comments

@hamirmahal
Copy link

  • Write a summary of your issue
  • Include a link to a github repo that can be used to reproduce the issue or exact reproduction steps.
  • Provide the expected result
  • Provide the actual result
  • Include extension, os, and vs code information
  • Include Prettier extension log

Summary

esbenp.prettier-vscode isn't consistent with prettier in package.json.

esbenp.prettier-vscode doesn't format *.config.ts and test/ui/**.spec.ts files, but the prettier in package.json expects them to be.

esbenp.prettier-vscode should do the exact same formatting as the prettier in package.json.

Github Repository to Reproduce Issue

https://github.com/hamirmahal/prettier-formatting-issues

Steps To Reproduce:

  1. Try saving *.config.ts and test/ui/**.spec.ts files.
  2. The Prettier VSCode extension does not format them, and the prettier formatting check will fail.

Expected result

esbenp.prettier-vscode should format *.config.ts and test/ui/**.spec.ts files exactly as

"format": "prettier --write .",

would.

Actual result

esbenp.prettier-vscode doesn't format *.config.ts and test/ui/**.spec.ts files at all.

Additional information

VS Code Version:

Version: 1.90.1
Commit: 611f9bfce64f25108829dd295f54a6894e87339d
Date: 2024-06-11T21:02:43.666Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Linux x64 6.5.0-41-generic snap

Prettier Extension Version:
v10.4.0

OS and version: Linux x64 6.5.0-41-generic snap

Prettier Log Output

["DEBUG" - 1:20:17 PM] Local prettier module path: /home/hamir/prettier-formatting-issues/node_modules/prettier/index.cjs
["DEBUG" - 1:20:17 PM] Using prettier version 3.3.2
@hamirmahal
Copy link
Author

This might be related to #3431.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant