Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

'Only format' options disable formatting on save #360

Closed
SavePointSam opened this issue Jan 30, 2018 · 8 comments
Closed

'Only format' options disable formatting on save #360

SavePointSam opened this issue Jan 30, 2018 · 8 comments
Assignees
Labels

Comments

@SavePointSam
Copy link
Collaborator

Based on the conversation from #289, when enabling 'only format' type options disables formatting on save.

Not much else is known about this particular issue, though I have seen it myself as well.

@robwise
Copy link
Collaborator

robwise commented Jan 30, 2018

Might we just want to move over to checking the node modules instead? Although, that might have its own problems, such as for people who for whatever reason have put their node modules folders in unexpected places.

The related issue for that is #191

@leepowelldev
Copy link

Discovered this morning that 'Format on Save' beings working when I disable ESLint Integration.

@SavePointSam
Copy link
Collaborator Author

Thanks for the update! We do have some fallback logic to another package when you enable this feature. Maybe there is an issue on their end? Maybe we need to update our internal version?

@robwise
Copy link
Collaborator

robwise commented Feb 6, 2018

There recently was a bug with prettier-eslint specifically that was stopping it from working. That has since been fixed on their end and our packaged version updated. That issue was #334

@mikestopcontinues
Copy link

I'm not sure if this is related, but I could only get format-on-save working if "Only format if a Prettier config is found" was disabled... I use a "prettier" key in my package.json. Options I set there do affect results when running in the terminal.

@brettdewoody
Copy link

Same solution as @mikestopcontinues. I have a prettier key in package.json. With the 'Only format if Prettier is found in your project's dependencies' enabled, Prettier does not format on save. When I disable that option, and have 'Only format if a Prettier config is found' enabled, Prettier formats on save.

@olsonpm
Copy link
Contributor

olsonpm commented Mar 23, 2018

if you post a sample github repo reproducing your issue I will look into the cause of this @brettdewoody

@robwise
Copy link
Collaborator

robwise commented Aug 20, 2018

This should probably be fixed in #404

@robwise robwise closed this as completed Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants