-
-
Notifications
You must be signed in to change notification settings - Fork 95
'Only format' options disable formatting on save #360
Comments
Might we just want to move over to checking the node modules instead? Although, that might have its own problems, such as for people who for whatever reason have put their node modules folders in unexpected places. The related issue for that is #191 |
Discovered this morning that 'Format on Save' beings working when I disable ESLint Integration. |
Thanks for the update! We do have some fallback logic to another package when you enable this feature. Maybe there is an issue on their end? Maybe we need to update our internal version? |
There recently was a bug with prettier-eslint specifically that was stopping it from working. That has since been fixed on their end and our packaged version updated. That issue was #334 |
I'm not sure if this is related, but I could only get format-on-save working if "Only format if a Prettier config is found" was disabled... I use a "prettier" key in my package.json. Options I set there do affect results when running in the terminal. |
Same solution as @mikestopcontinues. I have a |
if you post a sample github repo reproducing your issue I will look into the cause of this @brettdewoody |
This should probably be fixed in #404 |
Based on the conversation from #289, when enabling 'only format' type options disables formatting on save.
Not much else is known about this particular issue, though I have seen it myself as well.
The text was updated successfully, but these errors were encountered: