Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@typescript-eslint/block-spacing and @typescript-eslint/key-spacing are not turned off #242

Closed
8naf opened this issue Feb 22, 2023 · 4 comments
Closed

@typescript-eslint/block-spacing and @typescript-eslint/key-spacing are not turned off #242

8naf opened this issue Feb 22, 2023 · 4 comments

Comments

@8naf
Copy link

8naf commented Feb 22, 2023

Hi,
I noticed in the index.js file that you have turned off two rules: block-spacing and vue/block-spacing, but you didn't turn off @typescript-eslint/block-spacing. Similarly, key-spacing and vue/key-spacing have been turned off, but @typescript-eslint/key-spacing has not. Is there a reason for this ?
@lydell
Copy link
Member

lydell commented Feb 22, 2023 •
edited
Loading

Hi!

Those two @typescript-eslint rules are quite new and nobody has added them here yet. Would you like to make a PR?

@ttionya ttionya mentioned this issue Mar 3, 2023
Merged
@ttionya
Copy link
Contributor

ttionya commented Mar 3, 2023

Hi, I created a PR #243 for this issue.

@lydell
Copy link
Member

lydell commented Mar 6, 2023

Released in v8.7.0.

@lydell lydell closed this as completed Mar 6, 2023
@8naf
Copy link
Author

8naf commented Mar 7, 2023

@ttionya
Thank you for creating the pull request. I forgot that I had also created this issue 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lydell @ttionya @8naf