Correct wrong and misleading comments about enemy trainer AI #1149
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inaccurate comment.
Rephrase misleading comment about AI use of Rain Dance moves.
Rephrase misleading comments about AI use of Sunny Day moves.
AI_OPPORTUNIST checks enemy HP, not player.
Elaborate on AI use of "useful moves" in code comment.
Sync bug doc with Sunny Day moves list change.
Rangi42
reviewed
Nov 12, 2024
| @@ -1,5 +1,5 @@ | |||
| ; AI_OPPORTUNIST discourages these moves | |||
| ; when the player's HP is low. | |||
| ; when the enemy's HP is low. | |||
There was a problem hiding this comment.
Suggested change
| ; when the enemy's HP is low. | |
| ; when its HP is low. |
Rangi42
reviewed
Nov 12, 2024
|
|
||
| SunnyDayMoves: | ||
| ; BUG: "Smart" AI does not encourage Solar Beam, Flame Wheel, or Moonlight during Sunny Day (see docs/bugs_and_glitches.md) | ||
| ; BUG: Solar Beam, Flame Wheel, and Moonlight should be on this list (see docs/bugs_and_glitches.md) |
There was a problem hiding this comment.
Suggested change
| ; BUG: Solar Beam, Flame Wheel, and Moonlight should be on this list (see docs/bugs_and_glitches.md) | |
| ; BUG: "Smart" AI does not encourage Sunny Day when it knows Solar Beam, Flame Wheel, or Moonlight (see docs/bugs_and_glitches.md) |
Rangi42
reviewed
Nov 12, 2024
| @@ -1,4 +1,4 @@ | |||
| ; AI_SMART knows these moves are usable all-around. | |||
| ; AI_SMART tries to use Mirror Move, Mimic, and Disable on these moves. | |||
There was a problem hiding this comment.
Suggested change
| ; AI_SMART tries to use Mirror Move, Mimic, and Disable on these moves. | |
| ; AI_SMART tries to use Mirror Move, Mimic, and Disable | |
| ; after the player uses these moves. |
Rangi42
reviewed
Nov 12, 2024
| @@ -1267,13 +1267,13 @@ Pryce's dialog ("That BADGE will raise the SPECIAL stats of POKéMON.") implies | |||
| ``` | |||
|
|
|||
|
|
|||
| ### "Smart" AI does not encourage Solar Beam, Flame Wheel, or Moonlight during Sunny Day | |||
| ### "Smart" AI does not encourage Sunny Day if it knows Solar Beam, Flame Wheel, or Moonlight | |||
There was a problem hiding this comment.
Suggested change
| ### "Smart" AI does not encourage Sunny Day if it knows Solar Beam, Flame Wheel, or Moonlight | |
| ### "Smart" AI does not encourage Sunny Day when it knows Solar Beam, Flame Wheel, or Moonlight |
Rangi42
reviewed
Nov 12, 2024
|
|
||
| **Fix:** Edit `SunnyDayMoves` in [data/battle/ai/sunny_day_moves.asm](https://github.com/pret/pokecrystal/blob/master/data/battle/ai/sunny_day_moves.asm): | ||
|
|
||
| ```diff | ||
| SunnyDayMoves: | ||
| -; BUG: "Smart" AI does not encourage Solar Beam, Flame Wheel, or Moonlight during Sunny Day (see docs/bugs_and_glitches.md) | ||
| -; BUG: Solar Beam, Flame Wheel, and Moonlight should be on this list (see docs/bugs_and_glitches.md) |
There was a problem hiding this comment.
Suggested change
| -; BUG: Solar Beam, Flame Wheel, and Moonlight should be on this list (see docs/bugs_and_glitches.md) | |
| -; BUG: "Smart" AI does not encourage Sunny Day when it knows Solar Beam, Flame Wheel, or Moonlight (see docs/bugs_and_glitches.md) |
Rangi42
requested changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the enemy trainer AI, I noticed that some comments are misleading or flat-out wrong. The corrections are simple and self-explanatory. No idea if I'm doing the pull request right, though.