Move the description of Iceberg procedures to a dedicated subheading #22845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
1107
to
1108
| ======= | ||
| >>>>>>> Move the description of Iceberg procedures to a dedicated subheading |
There was a problem hiding this comment.
Here exists a conflict. Please handle it first.
There was a problem hiding this comment.
conflicts fixed.
|
@jackychen718 per our CONTRIBUTING.md, you need to make sure your commits are squashed. Please follow a resource on the internet if you don't know what this means--here is one article I found that may help. I'll mark this as draft, please take it out of draft once you've completed this, thanks! |
steveburnett
requested changes
May 28, 2024
jackychen718
force-pushed
the
procedure-in-doc
branch
from
27eac10
to
6fe844f
Compare
jackychen718
force-pushed
the
procedure-in-doc
branch
from
6fe844f
to
fa831dc
Compare
hantangwangd
approved these changes
May 29, 2024
There was a problem hiding this comment.
Thanks for the fix. Change looks good to me. Please take this PR out of draft following @tdcmeehan 's guidance.
|
Looks good to me. @steveburnett would you like to have a look? |
steveburnett
approved these changes
May 29, 2024
tdcmeehan
approved these changes
May 29, 2024
ZacBlanco
approved these changes
May 29, 2024
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According #22608:
Move the description of Iceberg procedures to a dedicated subheading.