-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native] Support system tables #21285
[native] Support system tables #21285
Conversation
The idea is to insert an extra "GATHER" exchange right on top of a TableScan of a system table. This will ensure partitioning function is applied by native worker consistently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arhimondr Thank you, Andrii, for enabling queries that use system tables on Prestissimo and Presto-on-Spark on Velox.
@mbasmanova Happy to help Presto on Spark (even with Java execution) is not supported though for a different reason. In Presto on Spark a distributed stage cannot read from a coordinator stage. Queries that require a system table to be read by a distributed stage (such as join) are not supported. |
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
Follow up of #21285 Partial aggregation output might not be compatible between Java and C++ implementations
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
Description
Querying system tables with native execution enabled may result in incorrect result.
Motivation and Context
Native and Java based executions have different partitioning functions implementation hence queries such the one below may return incorrect result.
Impact
Incorrect results returned when querying system tables with native execution enabled
Test Plan
Integration test
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: