Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we have existing Prometheus implementation for Velox BaseStatsReporter? #21615

Closed
xumingming opened this issue Dec 29, 2023 · 2 comments
Closed
Labels

Comments

@xumingming
Copy link
Contributor

The BaseStatsReporter used in Prestissimo is a dummy implementation, do we have Prometheus implementation available?

folly::Singleton<facebook::velox::BaseStatsReporter> reporter([]() {
return new facebook::velox::DummyStatsReporter();
});

@tdcmeehan
Copy link
Contributor

tdcmeehan commented Jan 2, 2024

This is being added in #21599

CC: @karteekmurthys

@xumingming
Copy link
Contributor Author

Since question already answered, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants