Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise the MIT license #647

Closed
mmmguitar opened this issue Nov 22, 2023 · 1 comment
Closed

Standardise the MIT license #647

mmmguitar opened this issue Nov 22, 2023 · 1 comment

Comments

@mmmguitar
Copy link
Contributor

mmmguitar commented Nov 22, 2023

We have licence scanners for compliance and its not able to identify the licence for goose which is causing some issues.

It seems a silly one but the LICENCE file for MIT appears to be non-standard in the way it's adding a title in the middle of the expected licence.

As far as I am aware the MIT licence should be formatted:

<copyrights>
<legals>

Where as the goose licence is:

<copyrights>
<MIT Licence title>
<legals>

Which appears to break the definition of the licence. Most open source libs appear to put the licence title at the top, leaving the licence below it in tact, i.e.:

<MIT Licence title>
<copyrights>
<legals>

Heres a link to SPDX's + open source initialtive definitions for the licence: https://spdx.org/licenses/MIT.html
https://opensource.org/license/mit/

So the change request here is just to just swap the title to the top before the copyrights.

As an aside I often see people using "The MIT License (MIT)" for the title. As far as I can understand there's no real standard on that. There appears to be a historic quirk on the licence file being called after what it was to a generic named "LICENCE" file with a title the top to denote the licence, and that's developed as the norm its seems.

@mmmguitar mmmguitar changed the title Standardise the MIT licence Standardise the MIT license Nov 22, 2023
@mfridman
Copy link
Collaborator

Fixed by #648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants