Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we have an option not to generate color escape sequences in goose output (ex: -no-color) #405

Closed
callaingit opened this issue Sep 21, 2022 · 3 comments · Fixed by #409

Comments

@callaingit
Copy link

callaingit commented Sep 21, 2022

Right now (using v3.6.1)

'''
2022/09/19 14:29:39 -- +goose Up
2022/09/19 14:29:39 �[90mStateMachine: 0 => 1�[00m ------------ We see [90m and [00m codes in there and makes the logs more difficult to read - ex: in Jenkins job logs, etc.
2022/09/19 14:29:39 insert into
...
'''

@mfridman
Copy link
Collaborator

mfridman commented Oct 5, 2022

Yep, sounds totally reasonable.

While we're here, let's also add support for NO_COLOR env. https://no-color.org/

@mfridman
Copy link
Collaborator

Both a flag -no-color and env variable NO_COLOR have been added.

@callaingit
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants