Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning is ok? #132

Closed
eaglemoor opened this issue Nov 26, 2018 · 3 comments
Closed

Warning is ok? #132

eaglemoor opened this issue Nov 26, 2018 · 3 comments

Comments

@eaglemoor
Copy link

2018/11/26 07:31:05 WARNING: Unexpected unfinished SQL query: -- +goose Up
-- SQL in this section is executed when the migration is applied.

UPDATE table SET flag = true WHERE uid = any ('{befaa2fe-958f-4253-b8c2-75cf7081bdbb,0824434f-4098-4467-af72-d4f702fed335,2a1c7bdb-05ea-492f-9e1c-b3999f79dcbc,0d1f4cf7-dc64-465b-a113-7cb1a9fac9de,c0829b3e-dea5-4ec0-96b0-f5cf1a798ee7,2abed4d9-5565-4885-bc96-f4ffccc6cba4}' :: uuid[]). Missing a semicolon?
2018/11/26 07:31:05 OK    20181126094414_cityHasAirports.sql

2018/11/26 07:31:05 OK    20181126094414_cityHasAirports.sql
2018/11/26 07:31:05 goose: no migrations to run. current version: 20181126094414

WARNING IS REALY OK????? WHAT????

@VojtechVitek
Copy link
Collaborator

@eaglemoor we're maintaining a very old codebase here, for the good of community.

Why don't you send a PR and help us instead of YELLING AT US?

@eaglemoor
Copy link
Author

Ok. @VojtechVitek how u think, can we also update goose status for check migration sql source for catch syntactic error on goose status ?

@VojtechVitek
Copy link
Collaborator

I think goose status can't check the SQL syntax. That's beyond that command's scope.

However, db-up or db-down should indeed error out on Unexpected unfinished SQL query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants