Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.1 remove lifecycle warning of using componentWillMount #969

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

lidaof
Copy link

@lidaof lidaof commented Jun 23, 2020

Description

sorry I am not a git pro....I created a branch based on 2.5.0 and then made edits based on that commit.

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@dylan-cm
Copy link

Where are we on this? How can I help resolve this?

@prescottprue prescottprue changed the base branch from master to v2.5.0 August 12, 2020 23:40
@prescottprue
Copy link
Owner

@wurst-case Thanks for the reminder - it was just waiting on me to make a branch which is pointing to the latest v2 commit (v2.5.0). Also going to setup publishing for the v2 series to a tag so that the latest v2 can always be available

@prescottprue prescottprue changed the base branch from v2.5.0 to v2 August 12, 2020 23:42
@prescottprue prescottprue merged commit b71bfc9 into prescottprue:v2 Aug 12, 2020
@prescottprue
Copy link
Owner

v2.5.1 has been released with the changes - now the previous branch and npm tag contain the current v2 version (couldn't use v2 as npm doesn't allow semver version in tags).

Will add a note to the README about this

@lidaof
Copy link
Author

lidaof commented Aug 18, 2020

Hi @prescottprue @wurst-case the edits I made just removed the warnings. Have you guys consider replace componentWillMount with getDerivedStateFromProps or componentDidUpdate? I think this will make it work with React 17 in future. or people should switch to v3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants