fix(storage): support only firestore when calling upload and writing to db #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #601 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 26 26
Lines 916 916
Branches 166 166
=======================================
Hits 719 719
Misses 197 197 |
|
Great find! Thanks for making a PR |
prescottprue
changed the title
prescottprue
pushed a commit
that referenced
this pull request
Jan 1, 2019
…to db - #601 Co-Authored-By: Aldira Putra Raharja <[email protected]>
prescottprue
added a commit
that referenced
this pull request
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using only firestore and want to write to db to firestore. The checking is incorrect because it only consider
firebase.databasebut notfirebase.firestorewhen write metadata to dbCheck List
If not relevant to pull request, check off as complete
Relevant Issues
#600