PBJS Core: canBidderRegisterSync ignoring iframe sync disabled by def…

…ault (prebid#6535) * Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js * Update userSync.js * Update userSync_spec.js
prebidtappx · Apr 13, 2021 · a265241 · a265241
1 parent e35140a
commit a265241
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/userSync.js b/src/userSync.js
@@ -225,7 +225,7 @@ export function newUserSync(userSyncDependencies) {
       }
       return checkForFiltering[filterType](biddersToFilter, bidder);
     }
-    return false;
+    return !permittedPixels[type];
   }
 
   /**

diff --git a/test/spec/userSync_spec.js b/test/spec/userSync_spec.js
@@ -475,6 +475,24 @@ describe('user sync', function () {
           });
           expect(userSync.canBidderRegisterSync('iframe', 'otherTestBidder')).to.equal(false);
         });
+        it('should return false for iframe if there is no iframe filterSettings', function () {
+          const userSync = newUserSync({
+            config: {
+              syncEnabled: true,
+              filterSettings: {
+                image: {
+                  bidders: '*',
+                  filter: 'include'
+                }
+              },
+              syncsPerBidder: 5,
+              syncDelay: 3000,
+              auctionDelay: 0
+            }
+          });
+
+          expect(userSync.canBidderRegisterSync('iframe', 'otherTestBidder')).to.equal(false);
+        });
         it('should return true if filter settings does allow it', function () {
           const userSync = newUserSync({
             config: {
-Original file line number
+Diff line change
@@ Expand Up / @@ -225,7 +225,7 @@ export function newUserSync(userSyncDependencies) { @@
           }
           return checkForFiltering[filterType](biddersToFilter, bidder);
         }
-        return false;
+        return !permittedPixels[type];
       }
       /**
@@ Expand Down @@