Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eskimi bidder documentation #4471

Merged
merged 2 commits into from
May 18, 2023
Merged

Add Eskimi bidder documentation #4471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9d099
Add Eskimi bidder documentation
mrobakowski Apr 6, 2023
a67103c
add safeframes_ok and ortb_blocking_supported fields to eskimi bidder…
mrobakowski May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions dev-docs/bidders/eskimi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
layout: bidder
title: Eskimi
description: Prebid Eskimi Bidder Adapter
pbjs: true
pbs: false
biddercode: eskimi
deals_supported: false
media_types: banner
gvl_id: 814
sidebarType: 1
schain_supported: true
floors_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleased add additional meta information found here: https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

  • media_types : banner // this is not needed, but makes it clearer
  • safeframes_ok: true/false // makes the integration easier for publishers
  • ortb_blocking_supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add additional bidder parameters for ortb blocking? In the adapter code we're using prebid.js's ortb converter, but that won't populate bcat, badv and so on, right? So I guess for the initial version ortb_blocking_supported will be set to false, but we're going to update it later as our backend supports it fully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrobakowski sounds like a good plan to me. Merging!

safeframes_ok: false
ortb_blocking_supported: false
---


### Bid Params

{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|-------------------|----------|-------------------------------|---------|------------|
| `placementId` | required | The placement ID from Eskimi. | `612` | `integer` |