From 75e09247f3b31c473aef41befececa091c729e6f Mon Sep 17 00:00:00 2001 From: Cameron Rice Date: Fri, 21 Aug 2020 14:52:35 -0700 Subject: [PATCH 1/2] Fixing comment for usage of deal priority field --- adapters/bidder.go | 2 +- exchange/bidder.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/adapters/bidder.go b/adapters/bidder.go index 627caf67344..507e5be0273 100644 --- a/adapters/bidder.go +++ b/adapters/bidder.go @@ -108,7 +108,7 @@ func NewBidderResponse() *BidderResponse { // TypedBid.Bid.Ext will become "response.seatbid[i].bid.ext.bidder" in the final OpenRTB response. // TypedBid.BidType will become "response.seatbid[i].bid.ext.prebid.type" in the final OpenRTB response. // TypedBid.BidVideo will become "response.seatbid[i].bid.ext.prebid.video" in the final OpenRTB response. -// TypedBid.DealPriority will become "response.seatbid[i].bid.dealPriority" in the final OpenRTB response. +// TypedBid.DealPriority is used internally for supporting deal targeted campaigns type TypedBid struct { Bid *openrtb.Bid BidType openrtb_ext.BidType diff --git a/exchange/bidder.go b/exchange/bidder.go index decad8ccf2f..2f92b40ecda 100644 --- a/exchange/bidder.go +++ b/exchange/bidder.go @@ -57,7 +57,7 @@ type adaptedBidder interface { // pbsOrtbBid.bidType will become "response.seatbid[i].bid.ext.prebid.type" in the final OpenRTB response. // pbsOrtbBid.bidTargets does not need to be filled out by the Bidder. It will be set later by the exchange. // pbsOrtbBid.bidVideo is optional but should be filled out by the Bidder if bidType is video. -// pbsOrtbBid.dealPriority will become "response.seatbid[i].bid.dealPriority" in the final OpenRTB response. +// pbsOrtbBid.dealPriority is used internally for supporting deal targeted campaigns type pbsOrtbBid struct { bid *openrtb.Bid bidType openrtb_ext.BidType From b4fd2a2a0b510823fffd16960ee78146ddf5a88f Mon Sep 17 00:00:00 2001 From: Cameron Rice Date: Mon, 24 Aug 2020 16:11:23 -0700 Subject: [PATCH 2/2] Updating comment with suggested phrasing --- adapters/bidder.go | 2 +- exchange/bidder.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/adapters/bidder.go b/adapters/bidder.go index 507e5be0273..41218aa6a2f 100644 --- a/adapters/bidder.go +++ b/adapters/bidder.go @@ -108,7 +108,7 @@ func NewBidderResponse() *BidderResponse { // TypedBid.Bid.Ext will become "response.seatbid[i].bid.ext.bidder" in the final OpenRTB response. // TypedBid.BidType will become "response.seatbid[i].bid.ext.prebid.type" in the final OpenRTB response. // TypedBid.BidVideo will become "response.seatbid[i].bid.ext.prebid.video" in the final OpenRTB response. -// TypedBid.DealPriority is used internally for supporting deal targeted campaigns +// TypedBid.DealPriority is optionally provided by adapters and used internally by the exchange to support deal targeted campaigns. type TypedBid struct { Bid *openrtb.Bid BidType openrtb_ext.BidType diff --git a/exchange/bidder.go b/exchange/bidder.go index 2f92b40ecda..5924e39b031 100644 --- a/exchange/bidder.go +++ b/exchange/bidder.go @@ -57,7 +57,7 @@ type adaptedBidder interface { // pbsOrtbBid.bidType will become "response.seatbid[i].bid.ext.prebid.type" in the final OpenRTB response. // pbsOrtbBid.bidTargets does not need to be filled out by the Bidder. It will be set later by the exchange. // pbsOrtbBid.bidVideo is optional but should be filled out by the Bidder if bidType is video. -// pbsOrtbBid.dealPriority is used internally for supporting deal targeted campaigns +// pbsOrtbBid.dealPriority is optionally provided by adapters and used internally by the exchange to support deal targeted campaigns. type pbsOrtbBid struct { bid *openrtb.Bid bidType openrtb_ext.BidType