ORTB Blocking module: lack of media type strictness configuration for battr

[Net-burst]

There seems to be a design flaw with the blocking module. It was there from the moment the blocking module was initially released, but it became apparent only after we added video and audio support.

The issue lies in the fact that the blocking module doesn't care whether there is a media type object present for the purposes of adding battr. If an account has a configuration for banner/video/audio battr, the module will populate imp[].banner/video/audio.battr even if imp[].banner/video/audio doesn't exist. This would result in the impression potentially having multiple (basically bogus) media types.

Considering that this logic hasn't changed since 2021, I propose adding a control knob for this behavior: hooks.modules.ortb2-blocking.attributes.battr.strict-media-type.

Before injecting a MEDIA_TYPE (banner/video/audio) battr check for strict-media-type:

• if imp[].MEDIA_TYPE is not null continue with the existing logic;
• else if imp[].MEDIA_TYPE is null, additionally check for strict-media-type config:
  • if strict-media-type is set to true, skip this MEDIA_TYPE and don't inject battr;
  • if strict-media-type is set to false, apply existing logic: create a new MEDIA_TYPE object inside imp and inject battr.

[justadreamer]

Why introduce another config option and not simply fix it?
i.e.:
if imp[].MEDIA_TYPE is null skip this MEDIA_TYPE and don't inject battr;

[bsardo]

Discussed in committee. @bretg do you recall why this module was designed this way? The general opinion here is that this a bug but there is some concern as to whether we should consider this a breaking change such that backwards compatibility should be considered.