-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET https://vendor-list.consensu.org/vendorlist.json returned 403. #1689
Comments
The IAB asked us to switch to Please see issue #1687 for how to extend the default timeouts. The issue is less dire than the error suggests, as PBS will try to reload the GVL again when it's running. The IAB is no longer hosting |
Ok for the TCF1 url, indeed this error was only with 0.144.0 and not 0.145.0 However, I still have an error "GET https://vendor-list.consensu.org/v2/archives/vendor-list-v1.json returned malformed JSON. Cookie syncs may be affected" which is not related with timeout. I did saw issue #1687 and configured the timeouts to 1000ms, but the error is about malformed JSON so its not a timeout issue as the file was loaded. Here is the full message : I checked with json validators as this JSON was valid and not malformed. |
Ah, gotcha. Thank you for clarifying. It seems our GVL parser is complaining about no vendors. I don't really see why it should. @hhhjort Do you see any issue with removing that error check? |
I checked and indeed vendors don't show up until v2 of the GVL2. I think the point of check is to ensure that PBS could properly fetch the GVL, so perhaps we should switch the check to not check v1 specifically, so general failures might still be noticed. |
If it's valid for the GVL to not define any vendors, should we just remove that check? Wouldn't the successful parsing of the json indicate success? Perhaps we could add a 0 length response check in its place. I'm not sure if other parts of code make an assumption that the vendors list has a length of at least 1. |
It makes sense that v1 does not have vendors. The file also defines the purposes, so I can see v1 being released so that vendors can figure out what purposes they want to declare, and v2 then containing the first batch of vendor submissions. Thus v2 would be the first version that is useful for enforcing the GDPR, vs. v1 being useful only for vendors who need to know what the purposes are so that they can make their submissions. Any subsequent release should always contain vendors unless they are making some sort of breaking change, but don't want to increment the meta-version number to 3. |
The first version of the GVL for TCF2 will no longer be preloaded starting with PBS-Go 0.148.0. |
Was closed automatically when merging in the go-gdpr linked issue. Reopening until PBS is using a newer go-gpdr version for a definitive solution. |
PBS is now using the latest go-gdpr version v0.9.0. |
Hi,
Starting server with release 0.144.0 and 0.145.0 I can have these errors at startup :
E0201 17:04:35.657377 930154 vendorlist-fetching.go:150] GET https://vendor-list.consensu.org/vendorlist.json returned 403. Cookie syncs may be affected.
E0201 17:04:35.681586 930154 vendorlist-fetching.go:160] GET https://vendor-list.consensu.org/v2/archives/vendor-list-v1.json returned malformed JSON. Cookie syncs may be affected. Error was data.vendors was undefined or had no elements. Body was...
I don't have them with previous releases. Any idea why can be wrong here ? What could I check ?
Thanks
The text was updated successfully, but these errors were encountered: