Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal Support : response.seatbid[i].bid.dealPriority; Is it standard oRTB response #1445

Closed
ShriprasadM opened this issue Aug 19, 2020 · 6 comments
Closed

Deal Support : response.seatbid[i].bid.dealPriority; Is it standard oRTB response #1445

ShriprasadM opened this issue Aug 19, 2020 · 6 comments
Assignees
@camrice

Comments

@ShriprasadM
Copy link
Contributor

  1. As per the implementation added in https://github.com/prebid/prebid-server/pull/1183/files , adapters/bidder.go
  2. It is mentioned in the comment that for dealPriority -
    TypedBid.DealPriority will become "response.seatbid[i].bid.dealPriority" in the final OpenRTB response.
  3. Can someone point to oRTB specification, where the "response.seatbid[i].bid.dealPriority" is mentioned as standarized parameter ?
@ShriprasadM ShriprasadM changed the title Deal Support : response.seatbid[i].bid.dealPriority is it standard oRTB response Deal Support : response.seatbid[i].bid.dealPriority; Is it standard oRTB response Aug 19, 2020
@SyntaxNode
Copy link
Contributor

@camrice Can you please address this question?

@camrice
Copy link
Contributor

camrice commented Aug 20, 2020

Hi @ShriprasadM, thank you for pointing this out. The comment for the DealPriority field is incorrect and should be updated. It is not a standard OpenRTB field for bids nor is it returned in the final response. It is only used internally to Prebid Server for the deal prefixes. I will update the comment to make it accurate.

@ShriprasadM
Copy link
Contributor Author

Thank you @camrice

@camrice
Copy link
Contributor

camrice commented Aug 21, 2020

No problem! I will tag this issue on the update.

@camrice camrice mentioned this issue Aug 21, 2020
Merged
@SyntaxNode
Copy link
Contributor

@camrice @ShriprasadM Can this issue been closed? Has it been fully addressed?

@ShriprasadM
Copy link
Contributor Author

@SyntaxNode Yes we can close this issue

@ShriprasadM ShriprasadM mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camrice camrice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SyntaxNode @ShriprasadM @camrice