Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty httpcalls array for bidder. #1344

Closed
moteus opened this issue Jun 8, 2020 · 3 comments · Fixed by #1373
Closed

Empty httpcalls array for bidder. #1344

moteus opened this issue Jun 8, 2020 · 3 comments · Fixed by #1373

Comments

@moteus
Copy link

moteus commented Jun 8, 2020

I just try to make a request for the Pubnative bidder with test flag on, but got a response like

{
  "id": "***",
  "ext": {
    "debug": {
      "httpcalls": {
        "pubnative": [] <------ here empty array.
      },
      "resolvedrequest": {<HERE MY REQUEST>}
      }
    },
    "responsetimemillis": {
      "pubnative": 315
    },
    "tmaxrequest": 800
  }
}

I suspect this is because of the pubnative adapter set the test flag to 0

@moteus moteus changed the title Missing httpcalls array for bidder. Empty httpcalls array for bidder. Jun 8, 2020
@SyntaxNode
Copy link
Contributor

That seems very likely, yes. I'll discuss this with the team early next week. Perhaps we should record the value of the test flag before the adapter does its thing and modifies the request.

@bretg
Copy link
Contributor

bretg commented Jun 24, 2020

@fhartwig - would like to understand why your adapter is ignoring/overriding the test flag. In general, the expected behavior for bidders would be to discount impressions when 'test' is specified. If the aim is to avoid test requests to your bidder, I would think your adapter would just invalidate the auction rather than ignoring the explicit signal that this isn't a normal user.

Note that this relates tangentially to #745 -- where we define a separate flag for "debug" vs "test". It's an important distinction:

  • test means this isn't a real user. the bidder probably shouldn't charge for the bid.
  • debug means it could be a real user, but the publisher wants the extra tracing for confirmation or troubleshooting

@SyntaxNode - is support for the debug flag still on your radar?

@fhartwig
Copy link
Contributor

@fhartwig - would like to understand why your adapter is ignoring/overriding the test flag. In general, the expected behavior for bidders would be to discount impressions when 'test' is specified. If the aim is to avoid test requests to your bidder, I would think your adapter would just invalidate the auction rather than ignoring the explicit signal that this isn't a normal user.

@bretg I don't think there is a good reason for this behaviour, it's probably just something that was left over from the initial development and testing of the adapter. I will prepare a PR to remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants