-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty httpcalls array for bidder. #1344
Comments
That seems very likely, yes. I'll discuss this with the team early next week. Perhaps we should record the value of the test flag before the adapter does its thing and modifies the request. |
@fhartwig - would like to understand why your adapter is ignoring/overriding the test flag. In general, the expected behavior for bidders would be to discount impressions when 'test' is specified. If the aim is to avoid test requests to your bidder, I would think your adapter would just invalidate the auction rather than ignoring the explicit signal that this isn't a normal user. Note that this relates tangentially to #745 -- where we define a separate flag for "debug" vs "test". It's an important distinction:
@SyntaxNode - is support for the debug flag still on your radar? |
@bretg I don't think there is a good reason for this behaviour, it's probably just something that was left over from the initial development and testing of the adapter. I will prepare a PR to remove this. |
I just try to make a request for the Pubnative bidder with test flag on, but got a response like
I suspect this is because of the pubnative adapter set the test flag to 0
The text was updated successfully, but these errors were encountered: