diff --git a/exchange/exchange.go b/exchange/exchange.go index a7e20327ba4..11ef9a987f5 100644 --- a/exchange/exchange.go +++ b/exchange/exchange.go @@ -34,9 +34,6 @@ type ContextKey string const DebugContextKey = ContextKey("debugInfo") -//type bidResponseExtConfig struct { -// includeDebugInfo, cacheBids, cacheVAST, returnCreative bool -//} type extCacheInstructions struct { cacheBids, cacheVAST, returnCreative bool } diff --git a/exchange/exchange_test.go b/exchange/exchange_test.go index ef8dc80bbb0..27a476fd9ed 100644 --- a/exchange/exchange_test.go +++ b/exchange/exchange_test.go @@ -461,7 +461,7 @@ func TestReturnCreativeEndToEnd(t *testing.T) { } } -func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or similar to this test +func TestGetBidCacheInfoEndToEnd(t *testing.T) { testUUID := "CACHE_UUID_1234" testExternalCacheScheme := "https" testExternalCacheHost := "www.externalprebidcache.net" @@ -508,7 +508,7 @@ func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or NURL: "", BURL: "", LURL: "", - AdM: "", + AdM: "", AdID: "", ADomain: nil, Bundle: "", @@ -610,7 +610,6 @@ func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or Seat: string(bidderName), Bid: []openrtb.Bid{ { - AdM: "", Ext: json.RawMessage(`{ "prebid": { "cache": { "bids": { "cacheId": "` + testUUID + `", "url": "` + testExternalCacheScheme + `://` + testExternalCacheHost + `/` + testExternalCachePath + `?uuid=` + testUUID + `" }, "key": "", "url": "" }`), }, }, @@ -634,8 +633,6 @@ func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or assert.NoErrorf(t, err, "[TestGetBidCacheInfo] Error found while trying to json parse the url field from actual build response. Message: %v \n", err) assert.Equal(t, expCacheURL, cacheURL, "[TestGetBidCacheInfo] cacheId field in ext should equal \"%s\" \n", expCacheURL) - - // compare cache URL } func TestBidReturnsCreative(t *testing.T) {