InMobi adapter changes to support mtype

prebid · Sep 14, 2024 · 73b2411 · 73b2411
1 parent 3e24be7
commit 73b2411
Show file tree

Hide file tree

Showing 8 changed files with 34 additions and 10 deletions.
diff --git a/adapters/inmobi/inmobi.go b/adapters/inmobi/inmobi.go
@@ -77,7 +77,7 @@ func (a *InMobiAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalR
 
 	for _, sb := range serverBidResponse.SeatBid {
 		for i := range sb.Bid {
-			mediaType := getMediaTypeForImp(sb.Bid[i].ImpID, internalRequest.Imp)
+			mediaType := getMediaTypeForImp(sb.Bid[i], internalRequest.Imp)
 			bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
 				Bid:     &sb.Bid[i],
 				BidType: mediaType,
@@ -118,10 +118,20 @@ func preprocess(imp *openrtb2.Imp) error {
 	return nil
 }
 
-func getMediaTypeForImp(impId string, imps []openrtb2.Imp) openrtb_ext.BidType {
+func getMediaTypeForImp(bid openrtb2.Bid, imps []openrtb2.Imp) openrtb_ext.BidType {
+	switch bid.MType {
+	case openrtb2.MarkupBanner:
+		return openrtb_ext.BidTypeBanner
+	case openrtb2.MarkupVideo:
+		return openrtb_ext.BidTypeVideo
+	case openrtb2.MarkupAudio:
+		return openrtb_ext.BidTypeAudio
+	case openrtb2.MarkupNative:
+		return openrtb_ext.BidTypeNative
+	}
 	mediaType := openrtb_ext.BidTypeBanner
 	for _, imp := range imps {
-		if imp.ID == impId {
+		if imp.ID == bid.ImpID {
 			if imp.Video != nil {
 				mediaType = openrtb_ext.BidTypeVideo
 			}

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-app-banner.json b/adapters/inmobi/inmobitest/exemplary/simple-app-banner.json
@@ -75,7 +75,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "bannerhtml",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 1
               }
             ]
           }
@@ -94,6 +95,7 @@
         "adm": "bannerhtml",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 1,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-app-native.json b/adapters/inmobi/inmobitest/exemplary/simple-app-native.json
@@ -73,7 +73,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "native-json",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 4
               }
             ]
           }
@@ -92,6 +93,7 @@
         "adm": "native-json",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 4,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-app-video.json b/adapters/inmobi/inmobitest/exemplary/simple-app-video.json
@@ -77,7 +77,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 2
               }
             ]
           }
@@ -96,6 +97,7 @@
         "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 2,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-web-banner.json b/adapters/inmobi/inmobitest/exemplary/simple-web-banner.json
@@ -73,7 +73,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "bannerhtml",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 1
               }
             ]
           }
@@ -92,6 +93,7 @@
         "adm": "bannerhtml",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 1,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-web-native.json b/adapters/inmobi/inmobitest/exemplary/simple-web-native.json
@@ -71,7 +71,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "native-json",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 4
               }
             ]
           }
@@ -90,6 +91,7 @@
         "adm": "native-json",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 4,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/exemplary/simple-web-video.json b/adapters/inmobi/inmobitest/exemplary/simple-web-video.json
@@ -75,7 +75,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 2
               }
             ]
           }
@@ -94,6 +95,7 @@
         "adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 2,
         "ext": {
           "prebid": {
             "meta": {

diff --git a/adapters/inmobi/inmobitest/supplemental/banner-format-coersion.json b/adapters/inmobi/inmobitest/supplemental/banner-format-coersion.json
@@ -81,7 +81,8 @@
                 "price": 2.0,
                 "id": "1234",
                 "adm": "bannerhtml",
-                "impid": "imp-id"
+                "impid": "imp-id",
+                "mtype": 1
               }
             ]
           }
@@ -100,6 +101,7 @@
         "adm": "bannerhtml",
         "crid": "123456789",
         "nurl": "https://some.event.url/params",
+        "mtype": 1,
         "ext": {
           "prebid": {
             "meta": {