Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Debug configuration in MobileSdkPassThrough #669

Closed
ValentinPostindustria opened this issue Aug 16, 2023 · 0 comments · Fixed by #759
Closed

Remove Debug configuration in MobileSdkPassThrough #669

ValentinPostindustria opened this issue Aug 16, 2023 · 0 comments · Fixed by #759
Assignees

Comments

@ValentinPostindustria
Copy link
Collaborator

We made a separation for creating MobileSdkPassThrough, because PS didn't support this feature.

            JSONObject rootJsonObject;
            if (!BuildConfig.DEBUG) {
                if (extJson.has("prebid")) {
                    rootJsonObject = extJson.getJSONObject("prebid");
                } else return null;
            } else {
                rootJsonObject = extJson;
            }

Now it supports. So we can remove this check. Change stored impressions. And remove BuildConfig.DEBUG checker in unit tests (MobileSdkPassThroughTest).

@jsligh jsligh linked a pull request Jun 3, 2024 that will close this issue
@jsligh jsligh moved this from Triage to In Progress in Prebid Mobile Prioritization Jun 3, 2024
@jsligh jsligh self-assigned this Jun 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Prebid Mobile Prioritization Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants