-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nativo Bid Adapter: Adding UserId support #9767
Merged
Merged
Changes from 55 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
38e1ade
Initial nativoBidAdapter document creation (js, md and spec)
jsfledd 0792373
Fulling working prebid using nativoBidAdapter. Support for GDPR and C…
jsfledd 008e906
Added defult size settings based on the largest ad unit. Added respon…
jsfledd 21f3e0c
Changed bidder endpoint url
jsfledd 1a33f2c
Changed double quotes to single quotes.
jsfledd 517cd5b
Reverted package-json.lock to remove modifications from PR
jsfledd 44bf428
Added optional bidder param 'url' so the ad server can force- match a…
jsfledd bfe0e1e
Lint fix. Added space after if.
jsfledd e927584
Added new QS param to send various adUnit data to adapter endpopint
jsfledd 8ac4419
Merged latest prebid master branch
jsfledd 26d8b86
Updated unit test for new QS param
jsfledd ead77de
Added qs param to keep track of ad unit refreshes
jsfledd 4ed371c
Merged latest prebid master
jsfledd e59a770
Merged latest. Added adUnitCode as alternate to placementID. Removed …
jsfledd c338c4d
Updated bidMap key default value
jsfledd bfe7b02
Updated refresh increment logic
jsfledd 06407a1
Merged latest
jsfledd 978ffd7
Refactored spread operator for IE11 support
jsfledd f74f370
Updated isBidRequestValid check
jsfledd e1554d0
Merge branch 'master' of https://github.com/prebid/Prebid.js
jsfledd 7b9c9bb
Refactored Object.enties to use Object.keys to fix CircleCI testing e…
jsfledd ffe4dc9
Merge remote-tracking branch 'Prebid_Official/master'
jsfledd 7274900
Updated bid mapping key creation to prioritize ad unit code over plac…
jsfledd 95cc80e
Added filtering by ad, advertiser and campaign.
jsfledd 6b248fc
Merge remote-tracking branch 'Prebid_Official/master'
jsfledd bea02d0
Merge remote-tracking branch 'Prebid_Official/master'
jsfledd a6fc789
Merged master
jsfledd 657b35e
merged with master
jsfledd 2c0c8f5
Added more robust bidDataMap with multiple key access
jsfledd 97f020d
Deduped filer values
jsfledd b23518f
Rolled back package.json
jsfledd 2eeaa47
Merged with latest upstream master branch
jsfledd 729e608
Duped upstream/master's package.lock file ... not sure how it got cha…
jsfledd f26e064
Small refactor of filterData length check. Removed comparison with 0 …
jsfledd 024d010
Merge branch 'upstream_master'
jsfledd 060ff4c
Added bid sizes to request
jsfledd 15d34f1
Fixed function name in spec. Added unit tests.
jsfledd 4ff5d1b
Merge branch 'upstream_master'
jsfledd 7874280
Added priceFloor module support
jsfledd 7619590
Added protection agains empty url parameter
jsfledd 0bdc853
Merge branch 'upstream_master'
jsfledd ee52fbb
Merged with latest
jsfledd c5b8fab
Changed ntv_url QS param to use referrer.location instead of referrer…
jsfledd 51ba485
Removed testing 'only' flag
jsfledd b682e0b
Merge branch 'upstream_master'
jsfledd 1c02303
Merge branch 'upstream_master'
jsfledd b6ba5b5
Added ntv_url QS param value validation
jsfledd e2bed09
Merge remote-tracking branch 'PrebidOfficial/master'
jsfledd b629344
Merge remote-tracking branch 'PrebidOfficial/master'
jsfledd e04cf3d
Added userId support
jsfledd e9bb4ab
Added unit tests, refactored for bugs
jsfledd ce1b931
Wrapped ajax in try/catch
jsfledd a3af4e2
Added more unit testing
jsfledd 883ebd3
Updated eid check for duplicate values. Removed error logging as we n…
jsfledd be48d28
Removed spec test .only. Fixed unit tests that were breaking.
jsfledd 79880a8
Added Prebid version to nativo exchange request
jsfledd dbc8618
Removed unused bidder methods
jsfledd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are not utilizing any of these functions it is probably cleaner to just remove them, since now they are just no-oping. I believe if you do not define them it will not execute. very tiny no big deal and outside of this PR's code changes.
But think its just cleaner to remove them.