Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID5 User ID Module - refactor fetch and add server-side config options #8784

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

smenzer
Copy link
Collaborator

@smenzer smenzer commented Aug 4, 2022

Type of change

  • Feature
  • Refactoring (no functional changes, no api changes)

This PR mostly refactors the process to request an ID5 ID from our servers, utilizing promises and better organizing the code. In doing so, we've also added a feature to allow config to be pulled down from our server (so publishers don't have to make changes to their website when they want to add features) and an optional ability to add extensions that get passed into the request for an ID5 ID that are used when determining the ID5 ID to provide back to the publisher.

smenzer added a commit to smenzer-forks/prebid.github.io that referenced this pull request Aug 4, 2022
@patmmccann patmmccann requested a review from jlukas79 August 4, 2022 14:27
smenzer added a commit to smenzer-forks/prebid.github.io that referenced this pull request Aug 4, 2022
@smenzer
Copy link
Collaborator Author

smenzer commented Aug 16, 2022

@jlukas79 can you please take a look at this?

@smenzer
Copy link
Collaborator Author

smenzer commented Aug 18, 2022

given the approval by @jlukas79 i am merging this

@smenzer smenzer merged commit f69cc66 into prebid:master Aug 18, 2022
@smenzer smenzer deleted the id5_configurable_fetch_flow branch August 18, 2022 23:02
fowler446 pushed a commit to prebid/prebid.github.io that referenced this pull request Aug 18, 2022
patmmccann added a commit that referenced this pull request Aug 21, 2022
* Readme: remove dead dev dependency and maintenance badges (#8849)

* Readme: remove dead dev dependency badge and issue

* Remove maintainability and add back issues

* Prebid 7.11.0 release

* Increment version to 7.12.0-pre

* Adriver Bid and Id Modules: buyerid bug fix (#8768)

* initial commit

* adriver id submodule add

* add id system tests, fix adriver bid adapter tests

* adriver: fix buyerid

* remarks fixing

* removal of excess

* delete custom parameter

* bug fixes

* handle native response privacy link (#8838)

Co-authored-by: Zicong Zhou <[email protected]>

* Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842)

Previously, the use of a native adunit was exclusive with the banner type.

* Ras Bid Adapter: support for SlotSequence parameter (#8792)

* add rasbidadapter pos param

* Read pos off the adunit

* rename conflicting pos parameter for clarity

* Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827)

* IX Bid Adapter: Native OpenRTB Request Support (#8853)

* fix native click trackers to only fire on click

* fix unit tests for ix

* remove version for native requests

* remove unnecessary request conversion

Co-authored-by: Zicong Zhou <[email protected]>

* Update Sonobi adapter with GVLID (#8860)

* dgkeyword RTD provider: fix tests causing ID5 test failures (#8862)

* Id5 id configurable fetch flow (#8784)

Co-authored-by: Paweł Kowalski <[email protected]>

* NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868)

* remove ortb2, get device/site manually

* updated tests

* remove fallbacks

* no need to craete variable if there is no fallback (return in place)

* removed one test case

Co-authored-by: Yakov Klein <[email protected]>

* adserver.js : remove unused code (#8855)

* Displayio Bid Adapter: custom render; fix eids payload (#8847)

* Custom render; call pubmatic get user id function is removed

* use refererInfo; remove call createEidsArray

* VidCrunch LLC bidder (#8872)

Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>
patmmccann added a commit that referenced this pull request Aug 31, 2022
* Create codeql-analysis.yml

* Update codeql-analysis.yml

* Update instream.html

* Update emx_digitalBidAdapter_spec.js

* Update index.js

* Update index.js

* Update index.js

* Merge master  (#8873)

* Readme: remove dead dev dependency and maintenance badges (#8849)

* Readme: remove dead dev dependency badge and issue

* Remove maintainability and add back issues

* Prebid 7.11.0 release

* Increment version to 7.12.0-pre

* Adriver Bid and Id Modules: buyerid bug fix (#8768)

* initial commit

* adriver id submodule add

* add id system tests, fix adriver bid adapter tests

* adriver: fix buyerid

* remarks fixing

* removal of excess

* delete custom parameter

* bug fixes

* handle native response privacy link (#8838)

Co-authored-by: Zicong Zhou <[email protected]>

* Criteo Bid Adapter - Add support for banner+native multiformat ad unit (#8842)

Previously, the use of a native adunit was exclusive with the banner type.

* Ras Bid Adapter: support for SlotSequence parameter (#8792)

* add rasbidadapter pos param

* Read pos off the adunit

* rename conflicting pos parameter for clarity

* Improve Digital adapter: refactor code to align with latest RAZR creative tags (#8827)

* IX Bid Adapter: Native OpenRTB Request Support (#8853)

* fix native click trackers to only fire on click

* fix unit tests for ix

* remove version for native requests

* remove unnecessary request conversion

Co-authored-by: Zicong Zhou <[email protected]>

* Update Sonobi adapter with GVLID (#8860)

* dgkeyword RTD provider: fix tests causing ID5 test failures (#8862)

* Id5 id configurable fetch flow (#8784)

Co-authored-by: Paweł Kowalski <[email protected]>

* NextMillenium Bid Adapter: Remove ortb2 referrerInfo (#8868)

* remove ortb2, get device/site manually

* updated tests

* remove fallbacks

* no need to craete variable if there is no fallback (return in place)

* removed one test case

Co-authored-by: Yakov Klein <[email protected]>

* adserver.js : remove unused code (#8855)

* Displayio Bid Adapter: custom render; fix eids payload (#8847)

* Custom render; call pubmatic get user id function is removed

* use refererInfo; remove call createEidsArray

* VidCrunch LLC bidder (#8872)

Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>

* Revert "Merge master  (#8873)" (#8911)

This reverts commit 07c5369.

* Update code scan config

* Update viewability

* Sanitize JSON for adgeneration

Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
JacobKlein26 added a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* Create codeql-analysis.yml

* Update codeql-analysis.yml

* Update instream.html

* Update emx_digitalBidAdapter_spec.js

* Update index.js

* Update index.js

* Update index.js

* Merge master  (prebid#8873)

* Readme: remove dead dev dependency and maintenance badges (prebid#8849)

* Readme: remove dead dev dependency badge and issue

* Remove maintainability and add back issues

* Prebid 7.11.0 release

* Increment version to 7.12.0-pre

* Adriver Bid and Id Modules: buyerid bug fix (prebid#8768)

* initial commit

* adriver id submodule add

* add id system tests, fix adriver bid adapter tests

* adriver: fix buyerid

* remarks fixing

* removal of excess

* delete custom parameter

* bug fixes

* handle native response privacy link (prebid#8838)

Co-authored-by: Zicong Zhou <[email protected]>

* Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842)

Previously, the use of a native adunit was exclusive with the banner type.

* Ras Bid Adapter: support for SlotSequence parameter (prebid#8792)

* add rasbidadapter pos param

* Read pos off the adunit

* rename conflicting pos parameter for clarity

* Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827)

* IX Bid Adapter: Native OpenRTB Request Support (prebid#8853)

* fix native click trackers to only fire on click

* fix unit tests for ix

* remove version for native requests

* remove unnecessary request conversion

Co-authored-by: Zicong Zhou <[email protected]>

* Update Sonobi adapter with GVLID (prebid#8860)

* dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862)

* Id5 id configurable fetch flow (prebid#8784)

Co-authored-by: Paweł Kowalski <[email protected]>

* NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868)

* remove ortb2, get device/site manually

* updated tests

* remove fallbacks

* no need to craete variable if there is no fallback (return in place)

* removed one test case

Co-authored-by: Yakov Klein <[email protected]>

* adserver.js : remove unused code (prebid#8855)

* Displayio Bid Adapter: custom render; fix eids payload (prebid#8847)

* Custom render; call pubmatic get user id function is removed

* use refererInfo; remove call createEidsArray

* VidCrunch LLC bidder (prebid#8872)

Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>

* Revert "Merge master  (prebid#8873)" (prebid#8911)

This reverts commit 07c5369.

* Update code scan config

* Update viewability

* Sanitize JSON for adgeneration

Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* Create codeql-analysis.yml

* Update codeql-analysis.yml

* Update instream.html

* Update emx_digitalBidAdapter_spec.js

* Update index.js

* Update index.js

* Update index.js

* Merge master  (prebid#8873)

* Readme: remove dead dev dependency and maintenance badges (prebid#8849)

* Readme: remove dead dev dependency badge and issue

* Remove maintainability and add back issues

* Prebid 7.11.0 release

* Increment version to 7.12.0-pre

* Adriver Bid and Id Modules: buyerid bug fix (prebid#8768)

* initial commit

* adriver id submodule add

* add id system tests, fix adriver bid adapter tests

* adriver: fix buyerid

* remarks fixing

* removal of excess

* delete custom parameter

* bug fixes

* handle native response privacy link (prebid#8838)

Co-authored-by: Zicong Zhou <[email protected]>

* Criteo Bid Adapter - Add support for banner+native multiformat ad unit (prebid#8842)

Previously, the use of a native adunit was exclusive with the banner type.

* Ras Bid Adapter: support for SlotSequence parameter (prebid#8792)

* add rasbidadapter pos param

* Read pos off the adunit

* rename conflicting pos parameter for clarity

* Improve Digital adapter: refactor code to align with latest RAZR creative tags (prebid#8827)

* IX Bid Adapter: Native OpenRTB Request Support (prebid#8853)

* fix native click trackers to only fire on click

* fix unit tests for ix

* remove version for native requests

* remove unnecessary request conversion

Co-authored-by: Zicong Zhou <[email protected]>

* Update Sonobi adapter with GVLID (prebid#8860)

* dgkeyword RTD provider: fix tests causing ID5 test failures (prebid#8862)

* Id5 id configurable fetch flow (prebid#8784)

Co-authored-by: Paweł Kowalski <[email protected]>

* NextMillenium Bid Adapter: Remove ortb2 referrerInfo (prebid#8868)

* remove ortb2, get device/site manually

* updated tests

* remove fallbacks

* no need to craete variable if there is no fallback (return in place)

* removed one test case

Co-authored-by: Yakov Klein <[email protected]>

* adserver.js : remove unused code (prebid#8855)

* Displayio Bid Adapter: custom render; fix eids payload (prebid#8847)

* Custom render; call pubmatic get user id function is removed

* use refererInfo; remove call createEidsArray

* VidCrunch LLC bidder (prebid#8872)

Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Demetrio Girardi <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>

* Revert "Merge master  (prebid#8873)" (prebid#8911)

This reverts commit 07c5369.

* Update code scan config

* Update viewability

* Sanitize JSON for adgeneration

Co-authored-by: Patrick McCann <[email protected]>
Co-authored-by: Chris Huie <[email protected]>
Co-authored-by: Prebid.js automated release <[email protected]>
Co-authored-by: m-oranskaya <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Co-authored-by: Zicong Zhou <[email protected]>
Co-authored-by: Léonard Labat <[email protected]>
Co-authored-by: wsusrasp <[email protected]>
Co-authored-by: Catalin Ciocov <[email protected]>
Co-authored-by: Mike Miller <[email protected]>
Co-authored-by: Scott Menzer <[email protected]>
Co-authored-by: Paweł Kowalski <[email protected]>
Co-authored-by: JacobKlein26 <[email protected]>
Co-authored-by: Yakov Klein <[email protected]>
Co-authored-by: caseywhitmire <[email protected]>
Co-authored-by: philan15 <[email protected]>
Co-authored-by: Gena <[email protected]>
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants