Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidWatch Analytics Adapter : limit bandwidth usage + refactory #8774

Merged
merged 4 commits into from
Aug 22, 2022
Merged

bidWatch Analytics Adapter : limit bandwidth usage + refactory #8774

merged 4 commits into from
Aug 22, 2022

Conversation

matthieularere-msq
Copy link
Contributor

@matthieularere-msq matthieularere-msq commented Aug 3, 2022

Type of change

  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other

Description of change

@matthieularere-msq
Copy link
Contributor Author

Once approved, could this be merged to both 7.x and 6.x ? Thanks

@ChrisHuie
Copy link
Collaborator

@matthieularere-msq this is actually probably the last weekish we are releasing to 6.x-legacy. If you really want it in both can you please submit this change to the 6 legacy branch and we should be able to get it in.

@matthieularere-msq
Copy link
Contributor Author

@ChrisHuie sure it makes sense. I just did it, thanks.

@matthieularere-msq
Copy link
Contributor Author

@ChrisHuie Could you restart circleci check please ? It does not seem like the error it failed on is related to my updates. I did not even made any changes since the previous commit which succeeded.
Thanks.

@ChrisHuie ChrisHuie requested a review from ncolletti August 9, 2022 16:46
@ChrisHuie ChrisHuie requested review from ChrisHuie and removed request for ncolletti August 9, 2022 16:47
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned ncolletti Aug 9, 2022
@ChrisHuie ChrisHuie merged commit 0b71a33 into prebid:master Aug 22, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…d#8774)

* bidWatch Analytics Adapter : code refactory

* Update bidwatchAnalyticsAdapter_spec.js

* Update bidwatchAnalyticsAdapter_spec.js
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…d#8774)

* bidWatch Analytics Adapter : code refactory

* Update bidwatchAnalyticsAdapter_spec.js

* Update bidwatchAnalyticsAdapter_spec.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants