-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system: adjust babel configuration to reduce bundle size #8732
Conversation
This seems to have broken our typescript build. During runtime we get the following error
https://stackoverflow.com/questions/43042889/typescript-referenceerror-exports-is-not-defined I'm trying to chase this down why it happens. Curious if others see this as well. |
I found: webpack/webpack#4039 (comment)
I assume we have to detangle the babel configs in our build. |
Now I found another bug. Prebid.js/src/secureCreatives.js Lines 25 to 29 in a231b0d
The
This was introduced in #8219 --- Update Maybe again related to our webpack build. |
Type of change
Description of change
This updates babel configuration to:
The result is ~10KB reduction in prebid-core and ~150KB overall.
Before:
After: