Topics FPD module: initial release #8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkimcm
reviewed
Jul 1, 2022
| if (name != null) { | ||
| datum.name = name; | ||
| } | ||
| return datum; |
There was a problem hiding this comment.
testing on Chrome beta, when you get topics like this from API,
[{"configVersion":"chrome.1","modelVersion":"2206021246","taxonomyVersion":"1","topic":301,"version":"chrome.1:1:2206021246"},{"configVersion":"chrome.1","modelVersion":"2206021246","taxonomyVersion":"1","topic":3,"version":"chrome.1:1:2206021246"}]
datum looks like this
[{"name":"domain","ext":{"segtax":600,"segclass":"1"},"segment":[{"id":"301"},{"id":"3"}]}]
There was a problem hiding this comment.
thank you! just to confirm, "domain" is a placeholder you chose, not the actual value of name - right?
There was a problem hiding this comment.
segclass should be "2206021246" here @dgirardi , not 1
vkimcm
approved these changes
Jul 1, 2022
patmmccann
approved these changes
Jul 5, 2022
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* Topics FPD module * Small improvements
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
This reverts commit f567365.
1 task
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* Topics FPD module * Small improvements
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
This reverts commit f567365.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This adds a new
topicsFpdModulethat queries the topics api to populateuser.data.Since
document.browsingTopics()always returns an empty list for me, I need volunteers to test this in the real world.Other information
Closes #7968
Depends on #8626
Documentation TBD