Concert Bid Adapter: adding referrer #8580
Conversation
|
Circleci didn't run; typically it will if you unfollow your fork and make a tiny change |
I'm sorry, I'm not sure what you mean by "unfollow your fork"? (I'm going to try pushing a tiny inconsequential change to our branch, regardless, just to see.) |
|
I'm not sure how it works either, but you may have some levers to try in circleci? (I know if set up my fork in it - "follow" in their parlance - it will try to use a different account for PRs that come from that fork). |
|
Thanks for that, @dgirardi . I assumed that the circleci tests were run by this repo, rather than the source repo. I've tried to add our fork to circleci, but apparently I don't have sufficient admin access to the repo to allow that. 🙄 😞 . I'll have to try again next week. |
|
@andrew-a-dev CircleCi usually doesn't run because you are following your own fork in CircleCi instead of Prebid itself. If you go into CircleCI and unfollow your fork and rerun it will kick off the tests a lot of times. Also, if there is edit access on this pr I can kick off manually my making a commit. |
|
@ChrisHuie Thanks! I don't have access to any CircleCI running; I checked all over, and CircleCI can only see my personal repositories, not any |
|
@andrew-a-dev resubmitted this pr under #8676 :) |
…bid#8676) * Concert Bid Adapter refererInfo update * fix linting * update with purpose1consent
…bid#8676) * Concert Bid Adapter refererInfo update * fix linting * update with purpose1consent
…bid#8676) * Concert Bid Adapter refererInfo update * fix linting * update with purpose1consent
Type of change
Specifically: adding functionality to the existing Concert adapter
Description of change
Adding a
refparameter to the bid calls, using the various "referrer" properties available in Prebid.(The PR also contains linting-related changes to the file as a whole, to do with
;and whitespace.)Note
This PR was originally opened (and approved) here: #8564 -- but I unintentionally closed the PR by messing around with
masteron our forked repo. 🤦 Sorry. (It also includes an adjustment to that version, as per a suggestion from @dgirardi 🙌 )