Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-planning Bid Adapter: hostname modification #7474

Merged
merged 2 commits into from
Sep 29, 2021
Merged

E-planning Bid Adapter: hostname modification #7474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9290536
E-planning Bid Adapter hostname modification
matiasnfuentes Sep 24, 2021
0e9634f
Change of currency constant name in E-planning bid adapter
matiasnfuentes Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/eplanningBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export const storage = getStorageManager();

const BIDDER_CODE = 'eplanning';
const rnd = Math.random();
const DEFAULT_SV = 'ads.us.e-planning.net';
const DEFAULT_SV = 'pbjs.e-planning.net';
const DEFAULT_ISV = 'i.e-planning.net';
const PARAMS = ['ci', 'sv', 't', 'ml', 'sn'];
const DOLLARS = 'USD';
const DOLLAR_CODE = 'USD';
const NET_REVENUE = true;
const TTL = 120;
const NULL_SIZE = '1x1';
Expand Down Expand Up @@ -115,7 +115,7 @@ export const spec = {
ttl: TTL,
creativeId: ad.crid,
netRevenue: NET_REVENUE,
currency: DOLLARS,
currency: DOLLAR_CODE,
};
if (ad.adom) {
bidResponse.meta = {
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/eplanningBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ describe('E-Planning Adapter', function () {

it('should create the url correctly', function () {
const url = spec.buildRequests(bidRequests, bidderRequest).url;
expect(url).to.equal('https://ads.us.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS');
expect(url).to.equal('https://pbjs.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS');
});

it('should return GET method', function () {
Expand Down Expand Up @@ -740,7 +740,7 @@ describe('E-Planning Adapter', function () {
hasLocalStorageStub.returns(false);
const response = spec.buildRequests(bidRequests, bidderRequest);

expect(response.url).to.equal('https://ads.us.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS');
expect(response.url).to.equal('https://pbjs.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS');
expect(response.data.vs).to.equal('F');

sinon.assert.notCalled(getLocalStorageSpy);
Expand All @@ -750,7 +750,7 @@ describe('E-Planning Adapter', function () {
it('should create the url correctly with LocalStorage', function() {
createElementVisible();
const response = spec.buildRequests(bidRequests, bidderRequest);
expect(response.url).to.equal('https://ads.us.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS');
expect(response.url).to.equal('https://pbjs.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS');

expect(response.data.vs).to.equal('F');

Expand Down