Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vidoomy Bid Adapter: add new bid adapter #7178

Merged
merged 24 commits into from
Aug 3, 2021
Merged

Vidoomy Bid Adapter: add new bid adapter #7178

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1075bf3
added vidoomy bidder adapter with its tests and doc
mario-orle Jul 13, 2021
3193172
Merge branch 'prebid:master' into master
mario-orle Jul 13, 2021
5fe8100
typo
mario-orle Jul 16, 2021
5650435
Merge branch 'master' of https://github.com/mario-orle/Prebid.js
mario-orle Jul 16, 2021
34ccf7d
fix access to mediatypes
mario-orle Jul 16, 2021
0c149a4
switched lines
mario-orle Jul 16, 2021
bc3b277
null defence
mario-orle Jul 16, 2021
bbce8be
corrected request for test
mario-orle Jul 16, 2021
a267718
tests fixed
mario-orle Jul 16, 2021
6088a10
bad chai operator
mario-orle Jul 16, 2021
05921fe
not a function
mario-orle Jul 16, 2021
96fe5c7
responses goes with a body
mario-orle Jul 16, 2021
96f1ffb
avoid using urlsearchparams
mario-orle Jul 16, 2021
ef2115b
get hostname without using URL
mario-orle Jul 16, 2021
17a807d
added GVLID
mario-orle Jul 23, 2021
0ef891c
extra check for instream video size
mario-orle Jul 23, 2021
b7abe56
wrap hostname obtaining in trycathc
mario-orle Jul 23, 2021
d40f474
proper management of requestId
mario-orle Jul 23, 2021
4f4973d
error log when issues with renderer
mario-orle Jul 23, 2021
671dfca
explicitly parsing response from our server to prebid format
mario-orle Jul 23, 2021
12c550d
test fix
mario-orle Jul 23, 2021
9cb8918
added test for video bid request
mario-orle Jul 29, 2021
18054a7
added check to vidoomy server responses
mario-orle Jul 29, 2021
4d30ae8
fix failing test
mario-orle Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/vidoomyBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {config} from '../src/config.js';
import * as utils from '../src/utils.js';
import { Renderer } from '../src/Renderer.js';
import { OUTSTREAM } from '../src/video.js';
import { INSTREAM, OUTSTREAM } from '../src/video.js';

const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
const BIDDER_CODE = 'vidoomy';
Expand All @@ -24,6 +24,11 @@ const isBidRequestValid = bid => {
return false;
}

if (bid.params && bid.params.mediaTypes && bid.params.mediaTypes.video && bid.params.mediaTypes.context === INSTREAM && !bid.params.mediaTypes.video.playerSize) {
utils.logError(BIDDER_CODE + ': bid.params.mediaType.video should have a playerSize property to tell player size when is INSTREAM');
return false;
}
ncolletti marked this conversation as resolved.
Show resolved Hide resolved

return true;
};

Expand Down