From 1075bf3e707d56670bab9c01eb3888f099b9dc29 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Tue, 13 Jul 2021 20:47:16 +0200
Subject: [PATCH 01/22] added vidoomy bidder adapter with its tests and doc

---
 modules/vidoomyBidAdapter.js                | 127 +++++++++++++
 modules/vidoomyBidAdapter.md                |  59 ++++++
 test/spec/modules/vidoomyBidAdapter_spec.js | 190 ++++++++++++++++++++
 3 files changed, 376 insertions(+)
 create mode 100644 modules/vidoomyBidAdapter.js
 create mode 100644 modules/vidoomyBidAdapter.md
 create mode 100644 test/spec/modules/vidoomyBidAdapter_spec.js

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
new file mode 100644
index 00000000000..9ac6079e812
--- /dev/null
+++ b/modules/vidoomyBidAdapter.js
@@ -0,0 +1,127 @@
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+import {BANNER, VIDEO} from '../src/mediaTypes.js';
+import {config} from '../src/config.js';
+import * as utils from '../src/utils.js';
+import { Renderer } from '../src/Renderer.js';
+import { OUTSTREAM } from '../src/video.js';
+
+const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
+const BIDDER_CODE = 'vidoomy';
+const isBidRequestValid = bid => {
+  if (!bid.params) {
+    utils.logError(BIDDER_CODE + ': bid.params should be non-empty');
+    return false;
+  }
+
+  if (!+bid.params.pid) {
+    utils.logError(BIDDER_CODE + ': bid.params.pid should be non-empty Number');
+    return false;
+  }
+
+  if (!+bid.params.id) {
+    utils.logError(BIDDER_CODE + ': bid.params.id should be non-empty Number');
+    return false;
+  }
+
+  return true;
+};
+
+const buildRequests = (validBidRequests, bidderRequest) => {
+  const serverRequests = validBidRequests.map(bid => {
+    const adType = Object.keys(bid.mediaTypes)[0];
+
+    let w, h;
+
+    if (adType === VIDEO) {
+      [w, h] = bid.mediaTypes[adType].playerSize;
+    }
+
+    if (adType === BANNER) {
+      [w, h] = bid.mediaTypes[adType].sizes[0];
+    }
+    const videoContext = utils.deepAccess(bid, 'mediaTypes.video.context');
+
+    const queryParams = new URLSearchParams();
+    queryParams.append('id', bid.params.id);
+    queryParams.append('adtype', adType);
+    queryParams.append('w', w);
+    queryParams.append('h', h);
+    queryParams.append('pos', parseInt(bid.params.position) || 1);
+    queryParams.append('ua', navigator.userAgent);
+    queryParams.append('l', navigator.language && navigator.language.indexOf('-') !== -1 ? navigator.language.split('-')[0] : '');
+    queryParams.append('dt', /Mobi/.test(navigator.userAgent) ? 2 : 1);
+    queryParams.append('pid', bid.params.pid);
+    queryParams.append('dealId', bid.bidId);
+    queryParams.append('d', new URL(bidderRequest.refererInfo.referer).hostname);
+    queryParams.append('sp', encodeURIComponent(bidderRequest.refererInfo.referer));
+    if (bidderRequest.gdprConsent) {
+      queryParams.append('gdpr', bidderRequest.gdprConsent.gdprApplies);
+      queryParams.append('gdprcs', bidderRequest.gdprConsent.consentString);
+    }
+    queryParams.append('usp', bidderRequest.uspConsent || '');
+    queryParams.append('coppa', !!config.getConfig('coppa'));
+
+    const url = `${ENDPOINT}?${queryParams.toString()}`;
+    return {
+      method: 'GET',
+      url: url,
+      data: {videoContext}
+    }
+  });
+  return serverRequests;
+};
+
+const render = (bid) => {
+  bid.ad = bid.vastUrl;
+  var obj = {
+    vastTimeout: 5000,
+    maxAllowedVastTagRedirects: 3,
+    allowVpaid: true,
+    autoPlay: true,
+    preload: true,
+    mute: true,
+  }
+  window.outstreamPlayer(bid, bid.adUnitCode, obj);
+}
+
+const interpretResponse = (serverResponse, bidRequest) => {
+  try {
+    let responseBody = serverResponse.body;
+    responseBody.requestId = responseBody.dealId;
+    if (responseBody.mediaType === 'video') {
+      responseBody.ad = responseBody.vastUrl;
+      const videoContext = bidRequest.data.videoContext;
+
+      if (videoContext === OUTSTREAM) {
+        try {
+          const renderer = Renderer.install({
+            id: bidRequest.bidId,
+            adunitcode: bidRequest.tagId,
+            loaded: false,
+            config: responseBody.mediaType,
+            url: responseBody.meta.rendererUrl
+          });
+          renderer.setRender(render);
+
+          responseBody.renderer = renderer;
+        } catch (e) {
+          responseBody.ad = responseBody.vastUrl;
+        }
+      }
+    }
+
+    return [responseBody];
+  } catch (e) {
+    return [];
+  }
+};
+
+export const spec = {
+  code: BIDDER_CODE,
+  supportedMediaTypes: [BANNER, VIDEO],
+  isBidRequestValid,
+  buildRequests,
+  interpretResponse,
+};
+
+registerBidder(spec);
diff --git a/modules/vidoomyBidAdapter.md b/modules/vidoomyBidAdapter.md
new file mode 100644
index 00000000000..11e0ad40dbb
--- /dev/null
+++ b/modules/vidoomyBidAdapter.md
@@ -0,0 +1,59 @@
+# Overview
+
+**Module Name:** Vidoomy Bid Adapter
+
+**Module Type:** Bidder Adapter
+
+**Maintainer:** support@vidoomy.com
+
+# Description
+
+Module to connect with Vidoomy, supporting banner and video
+ 
+# Test Parameters
+For banner
+```js
+var adUnits = [
+  {
+    code: 'test-ad',
+    mediaTypes: {
+        banner: {
+            sizes: [[300, 250]] // only first size will be accepted
+        }
+    },
+    bids: [
+      {
+        bidder: 'vidoomy',
+        params: {
+          id: '123123',
+          pid: '123123'
+        }
+      }
+    ]
+  }
+];
+```
+
+For video
+```js
+var adUnits = [
+  {
+    code: 'test-ad',
+    mediaTypes: {
+        video: {
+            context: 'outstream',
+            playerSize: [300, 250]
+        }
+    },
+    bids: [
+      {
+        bidder: 'vidoomy',
+        params: {
+          id: '123123',
+          pid: '123123'
+        }
+      }
+    ]
+  }
+];
+```
diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
new file mode 100644
index 00000000000..b66ef448578
--- /dev/null
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -0,0 +1,190 @@
+import { expect } from 'chai';
+import { spec } from 'modules/vidoomyBidadapter.js';
+import { newBidder } from 'src/adapters/bidderFactory.js';
+
+const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
+
+describe('vidoomyBidAdapter', function() {
+  const adapter = newBidder(spec);
+
+  describe('isBidRequestValid', function () {
+    let bid;
+    beforeEach(() => {
+      bid = {
+        'bidder': 'vidoomy',
+        'params': {
+          pid: '123123',
+          id: '123123'
+        },
+        'adUnitCode': 'code',
+        'sizes': [[300, 250]]
+      };
+    });
+
+    it('should return true when required params found', function () {
+      expect(spec.isBidRequestValid(bid)).to.equal(true);
+    });
+
+    it('should return false when pid is empty', function () {
+      bid.params.pid = '';
+      expect(spec.isBidRequestValid(bid)).to.equal(false);
+    });
+
+    it('should return false when id is empty', function () {
+      bid.params.id = '';
+      expect(spec.isBidRequestValid(bid)).to.equal(false);
+    });
+
+    it('should return false when require params are not passed', function () {
+      let bid = Object.assign({}, bid);
+      bid.params = {};
+      expect(spec.isBidRequestValid(bid)).to.equal(false);
+    });
+  });
+
+  describe('buildRequests', function () {
+    let bidRequests = [
+      {
+        'bidder': 'vidoomy',
+        'params': {
+          pid: '123123',
+          id: '123123'
+        },
+        'adUnitCode': 'code',
+        'sizes': [[300, 250], [200, 100]]
+      },
+      {
+        'bidder': 'vidoomy',
+        'params': {
+          pid: '456456',
+          id: '456456'
+        },
+        'adUnitCode': 'code2',
+        'sizes': [[400, 225]]
+      }
+    ];
+
+    let bidderRequest = {
+      refererInfo: {
+        numIframes: 0,
+        reachedTop: true,
+        referer: 'http://example.com',
+        stack: ['http://example.com']
+      }
+    };
+
+    const request = spec.buildRequests(bidRequests, bidderRequest);
+
+    it('sends bid request to our endpoint via GET', function () {
+      expect(request[0].method).to.equal('GET');
+      expect(request[1].method).to.equal('GET');
+    });
+
+    it('attaches source and version to endpoint URL as query params', function () {
+      expect(request[0].url).to.include(ENDPOINT);
+      expect(request[1].url).to.include(ENDPOINT);
+    });
+
+    it('only accepts first width and height sizes', function () {
+      expect(request[0].url).to.include('w=300');
+      expect(request[0].url).to.include('h=250');
+      expect(request[0].url).to.not.include('w=200');
+      expect(request[0].url).to.not.include('h=100');
+      expect(request[1].url).to.include('w=400');
+      expect(request[1].url).to.include('h=225');
+    });
+
+    it('should send id and pid parameters', function () {
+      expect(request[0].url).to.include('id=123123');
+      expect(request[0].url).to.include('pid=123123');
+      expect(request[1].url).to.include('id=456456');
+      expect(request[1].url).to.include('pid=456456');
+    });
+  });
+
+  describe('interpretResponse', function () {
+    const serverResponseVideo = {
+      body: {
+        'vastUrl': 'https:\/\/vpaid.vidoomy.com\/demo-ad\/tag.xml',
+        'mediaType': 'video',
+        'requestId': '123123',
+        'cpm': 3.265,
+        'currency': 'USD',
+        'width': 0,
+        'height': 300,
+        'creativeId': '123123',
+        'dealId': '23cb20aa264b72',
+        'netRevenue': true,
+        'ttl': 60,
+        'meta': {
+          'mediaType': 'video',
+          'rendererUrl': 'https:\/\/vpaid.vidoomy.com\/outstreamplayer\/bundle.js',
+          'advertiserDomains': ['vidoomy.com'],
+          'advertiserId': 123,
+          'advertiserName': 'Vidoomy',
+          'agencyId': null,
+          'agencyName': null,
+          'brandId': null,
+          'brandName': null,
+          'dchain': null,
+          'networkId': null,
+          'networkName': null,
+          'primaryCatId': 'IAB3-1',
+          'secondaryCatIds': null
+        }
+      }
+    }
+
+    const serverResponseBanner = {
+      body: {
+        'ad': '<iframe src=\'https:\/\/vidoomy.com\/render\/ad.html\' width=\'300\' height=\'250\' frameborder=\'0\' scrolling=\'no\' marginheight=\'0\' marginwidth=\'0\' topmargin=\'0\' leftmargin=\'0\'><\/iframe>',
+        'mediaType': 'banner',
+        'requestId': '123123',
+        'cpm': 4.94,
+        'currency': 'USD',
+        'width': 250,
+        'height': 300,
+        'creativeId': '123123',
+        'dealId': '230aa095cea76b',
+        'netRevenue': true,
+        'ttl': 60,
+        'meta': {
+          'mediaType': 'banner',
+          'advertiserDomains': ['vidoomy.com'],
+          'advertiserId': 123,
+          'advertiserName': 'Vidoomy',
+          'agencyId': null,
+          'agencyName': null,
+          'brandId': null,
+          'brandName': null,
+          'dchain': null,
+          'networkId': null,
+          'networkName': null,
+          'primaryCatId': 'IAB3-1',
+          'secondaryCatIds': null
+        }
+      }
+    }
+
+    it('should get the correct bid response for outstream video, with renderer, an url in ad, and a new requestId equal to dealId', function () {
+      const bidRequest = {
+        data: {
+          videoContext: 'outstream'
+        }
+      }
+
+      let result = spec.interpretResponse(serverResponseVideo, bidRequest);
+
+      expect(result[0].renderer).not.to.be.undefined();
+      expect(result[0].ad).to.equal(serverResponseVideo.vastUrl);
+      expect(result[0].requestId).to.equal(serverResponseVideo.dealId);
+    });
+
+    it('should get the correct bid response for banner with a new requestId equal to dealId', function () {
+      const bidRequest = {};
+      let result = spec.interpretResponse(serverResponseBanner, bidRequest);
+
+      expect(result[0].requestId).to.equal(serverResponseBanner.dealId);
+    });
+  });
+});

From 5fe8100d6f9c9469d880187a4c9d234ce031c723 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 10:05:37 +0200
Subject: [PATCH 02/22] typo

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index b66ef448578..62a3add2097 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { spec } from 'modules/vidoomyBidadapter.js';
+import { spec } from 'modules/vidoomyBidAdapter.js';
 import { newBidder } from 'src/adapters/bidderFactory.js';
 
 const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;

From 34ccf7dd3d172dae5b8355d3db407e4c793ffa16 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 10:15:09 +0200
Subject: [PATCH 03/22] fix access to mediatypes

---
 modules/vidoomyBidAdapter.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 9ac6079e812..323afb55c90 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -28,17 +28,17 @@ const isBidRequestValid = bid => {
 
 const buildRequests = (validBidRequests, bidderRequest) => {
   const serverRequests = validBidRequests.map(bid => {
-    const adType = Object.keys(bid.mediaTypes)[0];
+    let adType = BANNER;
 
     let w, h;
-
-    if (adType === VIDEO) {
-      [w, h] = bid.mediaTypes[adType].playerSize;
+    if (bid.mediaTypes && bid.mediaTypes[BANNER] && bid.mediaTypes[BANNER].sizes) {
+      [w, h] = bid.mediaTypes[BANNER].playerSize;
+      adType = BANNER;
+    } else if (bid.mediaTypes[VIDEO] && bid.mediaTypes[VIDEO].playerSize) {
+      [w, h] = bid.mediaTypes[VIDEO].sizes[0];
+      adType = VIDEO;
     }
 
-    if (adType === BANNER) {
-      [w, h] = bid.mediaTypes[adType].sizes[0];
-    }
     const videoContext = utils.deepAccess(bid, 'mediaTypes.video.context');
 
     const queryParams = new URLSearchParams();

From 0c149a4d4d31cebde2f13c0910b1cce1f441e1f3 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 10:20:14 +0200
Subject: [PATCH 04/22] switched lines

---
 modules/vidoomyBidAdapter.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 323afb55c90..5775d254c66 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -32,10 +32,10 @@ const buildRequests = (validBidRequests, bidderRequest) => {
 
     let w, h;
     if (bid.mediaTypes && bid.mediaTypes[BANNER] && bid.mediaTypes[BANNER].sizes) {
-      [w, h] = bid.mediaTypes[BANNER].playerSize;
+      [w, h] = bid.mediaTypes[BANNER].sizes[0];
       adType = BANNER;
     } else if (bid.mediaTypes[VIDEO] && bid.mediaTypes[VIDEO].playerSize) {
-      [w, h] = bid.mediaTypes[VIDEO].sizes[0];
+      [w, h] = bid.mediaTypes[VIDEO].playerSize;
       adType = VIDEO;
     }
 

From bc3b277e92a4a2ebca39f953b7ec27109051a9e2 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 10:29:03 +0200
Subject: [PATCH 05/22] null defence

---
 modules/vidoomyBidAdapter.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 5775d254c66..0eea61e30da 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -34,7 +34,7 @@ const buildRequests = (validBidRequests, bidderRequest) => {
     if (bid.mediaTypes && bid.mediaTypes[BANNER] && bid.mediaTypes[BANNER].sizes) {
       [w, h] = bid.mediaTypes[BANNER].sizes[0];
       adType = BANNER;
-    } else if (bid.mediaTypes[VIDEO] && bid.mediaTypes[VIDEO].playerSize) {
+    } else if (bid.mediaTypes && bid.mediaTypes[VIDEO] && bid.mediaTypes[VIDEO].playerSize) {
       [w, h] = bid.mediaTypes[VIDEO].playerSize;
       adType = VIDEO;
     }

From bbce8be340f8d5b1db7f02c22b395079658b6249 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 10:37:14 +0200
Subject: [PATCH 06/22] corrected request for test

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 62a3add2097..449ef4fd8e0 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -51,7 +51,12 @@ describe('vidoomyBidAdapter', function() {
           id: '123123'
         },
         'adUnitCode': 'code',
-        'sizes': [[300, 250], [200, 100]]
+        'mediaTypes': {
+          'banner': {
+            'context': 'outstream',
+            'sizes': [[300, 250], [200, 100]]
+          }
+        },
       },
       {
         'bidder': 'vidoomy',
@@ -59,8 +64,13 @@ describe('vidoomyBidAdapter', function() {
           pid: '456456',
           id: '456456'
         },
+        'mediaTypes': {
+          'video': {
+            'context': 'outstream',
+            'playerSize': [300, 250],
+          }
+        },
         'adUnitCode': 'code2',
-        'sizes': [[400, 225]]
       }
     ];
 

From a26771825d05a7ad9b334325782ea80bf45243ab Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 10:48:53 +0200
Subject: [PATCH 07/22] tests fixed

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 449ef4fd8e0..60a5600607f 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -67,7 +67,7 @@ describe('vidoomyBidAdapter', function() {
         'mediaTypes': {
           'video': {
             'context': 'outstream',
-            'playerSize': [300, 250],
+            'playerSize': [400, 225],
           }
         },
         'adUnitCode': 'code2',
@@ -185,7 +185,7 @@ describe('vidoomyBidAdapter', function() {
 
       let result = spec.interpretResponse(serverResponseVideo, bidRequest);
 
-      expect(result[0].renderer).not.to.be.undefined();
+      expect(result[0].renderer).to.not.be.undefined();
       expect(result[0].ad).to.equal(serverResponseVideo.vastUrl);
       expect(result[0].requestId).to.equal(serverResponseVideo.dealId);
     });
@@ -194,7 +194,7 @@ describe('vidoomyBidAdapter', function() {
       const bidRequest = {};
       let result = spec.interpretResponse(serverResponseBanner, bidRequest);
 
-      expect(result[0].requestId).to.equal(serverResponseBanner.dealId);
+      expect(result[0].requestId).to.equal(serverResponseBanner.body.dealId);
     });
   });
 });

From 6088a1063476bf5b0b9aa2d37966f8fa61aeb15a Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 11:03:06 +0200
Subject: [PATCH 08/22] bad chai operator

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 60a5600607f..2338b94f201 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -185,7 +185,7 @@ describe('vidoomyBidAdapter', function() {
 
       let result = spec.interpretResponse(serverResponseVideo, bidRequest);
 
-      expect(result[0].renderer).to.not.be.undefined();
+      expect(result[0].renderer).to.be.defined();
       expect(result[0].ad).to.equal(serverResponseVideo.vastUrl);
       expect(result[0].requestId).to.equal(serverResponseVideo.dealId);
     });

From 05921fe3adc1e632206073f5281f81c402168e70 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 11:12:45 +0200
Subject: [PATCH 09/22] not a function

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 2338b94f201..d90869596a4 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -185,7 +185,7 @@ describe('vidoomyBidAdapter', function() {
 
       let result = spec.interpretResponse(serverResponseVideo, bidRequest);
 
-      expect(result[0].renderer).to.be.defined();
+      expect(result[0].renderer).to.not.be.undefined;
       expect(result[0].ad).to.equal(serverResponseVideo.vastUrl);
       expect(result[0].requestId).to.equal(serverResponseVideo.dealId);
     });

From 96fe5c77c006b1dcf494dfdfdbb59241e401f062 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 11:14:55 +0200
Subject: [PATCH 10/22] responses goes with a body

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index d90869596a4..77f27685fa2 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -186,8 +186,8 @@ describe('vidoomyBidAdapter', function() {
       let result = spec.interpretResponse(serverResponseVideo, bidRequest);
 
       expect(result[0].renderer).to.not.be.undefined;
-      expect(result[0].ad).to.equal(serverResponseVideo.vastUrl);
-      expect(result[0].requestId).to.equal(serverResponseVideo.dealId);
+      expect(result[0].ad).to.equal(serverResponseVideo.body.vastUrl);
+      expect(result[0].requestId).to.equal(serverResponseVideo.body.dealId);
     });
 
     it('should get the correct bid response for banner with a new requestId equal to dealId', function () {

From 96f1ffbc4c9efa79bb147de488421ee4df2aabce Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 11:26:59 +0200
Subject: [PATCH 11/22] avoid using urlsearchparams

---
 modules/vidoomyBidAdapter.js | 38 +++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 18 deletions(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 0eea61e30da..ede92f95e77 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -41,27 +41,29 @@ const buildRequests = (validBidRequests, bidderRequest) => {
 
     const videoContext = utils.deepAccess(bid, 'mediaTypes.video.context');
 
-    const queryParams = new URLSearchParams();
-    queryParams.append('id', bid.params.id);
-    queryParams.append('adtype', adType);
-    queryParams.append('w', w);
-    queryParams.append('h', h);
-    queryParams.append('pos', parseInt(bid.params.position) || 1);
-    queryParams.append('ua', navigator.userAgent);
-    queryParams.append('l', navigator.language && navigator.language.indexOf('-') !== -1 ? navigator.language.split('-')[0] : '');
-    queryParams.append('dt', /Mobi/.test(navigator.userAgent) ? 2 : 1);
-    queryParams.append('pid', bid.params.pid);
-    queryParams.append('dealId', bid.bidId);
-    queryParams.append('d', new URL(bidderRequest.refererInfo.referer).hostname);
-    queryParams.append('sp', encodeURIComponent(bidderRequest.refererInfo.referer));
+    const queryParams = [];
+    queryParams.push(['id', bid.params.id]);
+    queryParams.push(['adtype', adType]);
+    queryParams.push(['w', w]);
+    queryParams.push(['h', h]);
+    queryParams.push(['pos', parseInt(bid.params.position) || 1]);
+    queryParams.push(['ua', navigator.userAgent]);
+    queryParams.push(['l', navigator.language && navigator.language.indexOf('-') !== -1 ? navigator.language.split('-')[0] : '']);
+    queryParams.push(['dt', /Mobi/.test(navigator.userAgent) ? 2 : 1]);
+    queryParams.push(['pid', bid.params.pid]);
+    queryParams.push(['dealId', bid.bidId]);
+    queryParams.push(['d', new URL(bidderRequest.refererInfo.referer).hostname]);
+    queryParams.push(['sp', encodeURIComponent(bidderRequest.refererInfo.referer)]);
     if (bidderRequest.gdprConsent) {
-      queryParams.append('gdpr', bidderRequest.gdprConsent.gdprApplies);
-      queryParams.append('gdprcs', bidderRequest.gdprConsent.consentString);
+      queryParams.push(['gdpr', bidderRequest.gdprConsent.gdprApplies]);
+      queryParams.push(['gdprcs', bidderRequest.gdprConsent.consentString]);
     }
-    queryParams.append('usp', bidderRequest.uspConsent || '');
-    queryParams.append('coppa', !!config.getConfig('coppa'));
+    queryParams.push(['usp', bidderRequest.uspConsent || '']);
+    queryParams.push(['coppa', !!config.getConfig('coppa')]);
 
-    const url = `${ENDPOINT}?${queryParams.toString()}`;
+    const rawQueryParams = queryParams.map(qp => qp.join('=')).join('&');
+
+    const url = `${ENDPOINT}?${rawQueryParams}`;
     return {
       method: 'GET',
       url: url,

From ef2115b81eb5f32fb2f02163120440cd4a5ad33e Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 16 Jul 2021 11:37:27 +0200
Subject: [PATCH 12/22] get hostname without using URL

---
 modules/vidoomyBidAdapter.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index ede92f95e77..a6da7f81bb9 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -39,6 +39,9 @@ const buildRequests = (validBidRequests, bidderRequest) => {
       adType = VIDEO;
     }
 
+    const host = bidderRequest.refererInfo.referer.split('#')[0].replace(/^(https\:\/\/|http\:\/\/)|(\/)$/g, '').split('/')[0];
+    const hostname = host.split(':')[0];
+
     const videoContext = utils.deepAccess(bid, 'mediaTypes.video.context');
 
     const queryParams = [];
@@ -52,7 +55,7 @@ const buildRequests = (validBidRequests, bidderRequest) => {
     queryParams.push(['dt', /Mobi/.test(navigator.userAgent) ? 2 : 1]);
     queryParams.push(['pid', bid.params.pid]);
     queryParams.push(['dealId', bid.bidId]);
-    queryParams.push(['d', new URL(bidderRequest.refererInfo.referer).hostname]);
+    queryParams.push(['d', hostname]);
     queryParams.push(['sp', encodeURIComponent(bidderRequest.refererInfo.referer)]);
     if (bidderRequest.gdprConsent) {
       queryParams.push(['gdpr', bidderRequest.gdprConsent.gdprApplies]);

From 17a807d0575283e8f5f2e3efac4a028721d1d8d7 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 15:03:37 +0200
Subject: [PATCH 13/22] added GVLID

---
 modules/vidoomyBidAdapter.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index a6da7f81bb9..0accbe555fb 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -7,6 +7,7 @@ import { OUTSTREAM } from '../src/video.js';
 
 const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
 const BIDDER_CODE = 'vidoomy';
+const GVLID = 380;
 const isBidRequestValid = bid => {
   if (!bid.params) {
     utils.logError(BIDDER_CODE + ': bid.params should be non-empty');
@@ -127,6 +128,7 @@ export const spec = {
   isBidRequestValid,
   buildRequests,
   interpretResponse,
+  gvlid: GVLID,
 };
 
 registerBidder(spec);

From 0ef891cd8ac96a1f43d7c7c2591c3f34672ce56a Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 15:07:24 +0200
Subject: [PATCH 14/22] extra check for instream video size

---
 modules/vidoomyBidAdapter.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 0accbe555fb..477ac2fef0b 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -3,7 +3,7 @@ import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {config} from '../src/config.js';
 import * as utils from '../src/utils.js';
 import { Renderer } from '../src/Renderer.js';
-import { OUTSTREAM } from '../src/video.js';
+import { INSTREAM, OUTSTREAM } from '../src/video.js';
 
 const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
 const BIDDER_CODE = 'vidoomy';
@@ -24,6 +24,11 @@ const isBidRequestValid = bid => {
     return false;
   }
 
+  if (bid.params && bid.params.mediaTypes && bid.params.mediaTypes.video && bid.params.mediaTypes.context === INSTREAM && !bid.params.mediaTypes.video.playerSize) {
+    utils.logError(BIDDER_CODE + ': bid.params.mediaType.video should have a playerSize property to tell player size when is INSTREAM');
+    return false;
+  }
+
   return true;
 };
 

From b7abe56e1088eab3d04b3ffbf802306bdd6057bc Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 15:15:11 +0200
Subject: [PATCH 15/22] wrap hostname obtaining in trycathc

---
 modules/vidoomyBidAdapter.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 477ac2fef0b..c9565139ce7 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -45,7 +45,16 @@ const buildRequests = (validBidRequests, bidderRequest) => {
       adType = VIDEO;
     }
 
-    const host = bidderRequest.refererInfo.referer.split('#')[0].replace(/^(https\:\/\/|http\:\/\/)|(\/)$/g, '').split('/')[0];
+    let host = '';
+    try {
+      host = bidderRequest.refererInfo.referer.split('#')[0].replace(/^(https\:\/\/|http\:\/\/)|(\/)$/g, '').split('/')[0];
+    } catch (eBidRequest) {
+      try {
+        host = window.location.href.replace(/^(https\:\/\/|http\:\/\/)|(\/)$/g, '').split('/')[0];
+      } catch (eLocationHref) {
+        host = window.location.href;
+      }
+    }
     const hostname = host.split(':')[0];
 
     const videoContext = utils.deepAccess(bid, 'mediaTypes.video.context');

From d40f474416bacf110ed5e6ba6cfc6d71d4c6b95c Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 15:18:57 +0200
Subject: [PATCH 16/22] proper management of requestId

---
 modules/vidoomyBidAdapter.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index c9565139ce7..3ff1e948119 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -69,7 +69,7 @@ const buildRequests = (validBidRequests, bidderRequest) => {
     queryParams.push(['l', navigator.language && navigator.language.indexOf('-') !== -1 ? navigator.language.split('-')[0] : '']);
     queryParams.push(['dt', /Mobi/.test(navigator.userAgent) ? 2 : 1]);
     queryParams.push(['pid', bid.params.pid]);
-    queryParams.push(['dealId', bid.bidId]);
+    queryParams.push(['requestId', bid.bidId]);
     queryParams.push(['d', hostname]);
     queryParams.push(['sp', encodeURIComponent(bidderRequest.refererInfo.referer)]);
     if (bidderRequest.gdprConsent) {
@@ -107,7 +107,6 @@ const render = (bid) => {
 const interpretResponse = (serverResponse, bidRequest) => {
   try {
     let responseBody = serverResponse.body;
-    responseBody.requestId = responseBody.dealId;
     if (responseBody.mediaType === 'video') {
       responseBody.ad = responseBody.vastUrl;
       const videoContext = bidRequest.data.videoContext;

From 4f4973db4bc6faccd218a2e5d12bc5b119171f6b Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 15:19:44 +0200
Subject: [PATCH 17/22] error log when issues with renderer

---
 modules/vidoomyBidAdapter.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 3ff1e948119..5b3f669b70b 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -125,6 +125,7 @@ const interpretResponse = (serverResponse, bidRequest) => {
           responseBody.renderer = renderer;
         } catch (e) {
           responseBody.ad = responseBody.vastUrl;
+          utils.logError(BIDDER_CODE + ': error while installing renderer to show outstream ad');
         }
       }
     }

From 671dfca95f37d9620f3c207338a848fffbfac41b Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 15:30:24 +0200
Subject: [PATCH 18/22] explicitly parsing response from our server to prebid
 format

---
 modules/vidoomyBidAdapter.js | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index 5b3f669b70b..c964752c769 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -129,9 +129,42 @@ const interpretResponse = (serverResponse, bidRequest) => {
         }
       }
     }
+    const bid = {
+      vastUrl: responseBody.vastUrl,
+      ad: responseBody.ad,
+      renderer: responseBody.renderer,
+      mediaType: responseBody.mediaType,
+      requestId: responseBody.requestId,
+      cpm: responseBody.cpm,
+      currency: responseBody.currency,
+      width: responseBody.width,
+      height: responseBody.height,
+      creativeId: responseBody.creativeId,
+      netRevenue: responseBody.netRevenue,
+      ttl: responseBody.ttl,
+      meta: {
+        mediaType: responseBody.meta.mediaType,
+        rendererUrl: responseBody.meta.rendererUrl,
+        advertiserDomains: responseBody.meta.advertiserDomains,
+        advertiserId: responseBody.meta.advertiserId,
+        advertiserName: responseBody.meta.advertiserName,
+        agencyId: responseBody.meta.agencyId,
+        agencyName: responseBody.meta.agencyName,
+        brandId: responseBody.meta.brandId,
+        brandName: responseBody.meta.brandName,
+        dchain: responseBody.meta.dchain,
+        networkId: responseBody.meta.networkId,
+        networkName: responseBody.meta.networkName,
+        primaryCatId: responseBody.meta.primaryCatId,
+        secondaryCatIds: responseBody.meta.secondaryCatIds
+      }
+    };
+
+    const bids = [bid];
 
-    return [responseBody];
+    return bids;
   } catch (e) {
+    utils.logError(BIDDER_CODE + ': error parsing server response to Prebid format');
     return [];
   }
 };

From 12c550d5ce88cc95ddd810c6bf055ef37980e915 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 23 Jul 2021 17:02:08 +0200
Subject: [PATCH 19/22] test fix

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 77f27685fa2..028e6b23e51 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -176,7 +176,7 @@ describe('vidoomyBidAdapter', function() {
       }
     }
 
-    it('should get the correct bid response for outstream video, with renderer, an url in ad, and a new requestId equal to dealId', function () {
+    it('should get the correct bid response for outstream video, with renderer, an url in ad, and same requestId', function () {
       const bidRequest = {
         data: {
           videoContext: 'outstream'
@@ -187,14 +187,14 @@ describe('vidoomyBidAdapter', function() {
 
       expect(result[0].renderer).to.not.be.undefined;
       expect(result[0].ad).to.equal(serverResponseVideo.body.vastUrl);
-      expect(result[0].requestId).to.equal(serverResponseVideo.body.dealId);
+      expect(result[0].requestId).to.equal(serverResponseVideo.body.requestId);
     });
 
-    it('should get the correct bid response for banner with a new requestId equal to dealId', function () {
+    it('should get the correct bid response for banner with same requestId', function () {
       const bidRequest = {};
       let result = spec.interpretResponse(serverResponseBanner, bidRequest);
 
-      expect(result[0].requestId).to.equal(serverResponseBanner.body.dealId);
+      expect(result[0].requestId).to.equal(serverResponseBanner.body.requestId);
     });
   });
 });

From 9cb8918da262409b39e6880fb643796481b58f2f Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Thu, 29 Jul 2021 23:39:10 +0200
Subject: [PATCH 20/22] added test for video bid request

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 028e6b23e51..7861262babe 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -35,11 +35,20 @@ describe('vidoomyBidAdapter', function() {
       expect(spec.isBidRequestValid(bid)).to.equal(false);
     });
 
-    it('should return false when require params are not passed', function () {
+    it('should return false when required params are not passed', function () {
       let bid = Object.assign({}, bid);
       bid.params = {};
       expect(spec.isBidRequestValid(bid)).to.equal(false);
     });
+
+    it('should return false when mediaType is video with INSTREAM context and lacks playerSize property', function () {
+      bid.params.mediaTypes = {
+        video: {
+          context: 'INSTREAM'
+        }
+      }
+      expect(spec.isBidRequestValid(bid)).to.equal(false);
+    });
   });
 
   describe('buildRequests', function () {

From 18054a763e5ded82154b9af1db37eb43319c056a Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Fri, 30 Jul 2021 00:03:34 +0200
Subject: [PATCH 21/22] added check to vidoomy server responses

---
 modules/vidoomyBidAdapter.js | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/modules/vidoomyBidAdapter.js b/modules/vidoomyBidAdapter.js
index c964752c769..b579de8618b 100644
--- a/modules/vidoomyBidAdapter.js
+++ b/modules/vidoomyBidAdapter.js
@@ -24,7 +24,7 @@ const isBidRequestValid = bid => {
     return false;
   }
 
-  if (bid.params && bid.params.mediaTypes && bid.params.mediaTypes.video && bid.params.mediaTypes.context === INSTREAM && !bid.params.mediaTypes.video.playerSize) {
+  if (bid.params && bid.params.mediaTypes && bid.params.mediaTypes.video && bid.params.mediaTypes.video.context === INSTREAM && !bid.params.mediaTypes.video.playerSize) {
     utils.logError(BIDDER_CODE + ': bid.params.mediaType.video should have a playerSize property to tell player size when is INSTREAM');
     return false;
   }
@@ -32,10 +32,23 @@ const isBidRequestValid = bid => {
   return true;
 };
 
+const isBidResponseValid = bid => {
+  if (!bid.requestId || !bid.cpm || !bid.ttl || !bid.currency) {
+    return false;
+  }
+  switch (bid.mediaType) {
+    case BANNER:
+      return Boolean(bid.width && bid.height && bid.ad);
+    case VIDEO:
+      return Boolean(bid.vastUrl);
+    default:
+      return false;
+  }
+}
+
 const buildRequests = (validBidRequests, bidderRequest) => {
   const serverRequests = validBidRequests.map(bid => {
     let adType = BANNER;
-
     let w, h;
     if (bid.mediaTypes && bid.mediaTypes[BANNER] && bid.mediaTypes[BANNER].sizes) {
       [w, h] = bid.mediaTypes[BANNER].sizes[0];
@@ -160,7 +173,13 @@ const interpretResponse = (serverResponse, bidRequest) => {
       }
     };
 
-    const bids = [bid];
+    const bids = [];
+
+    if (isBidResponseValid(bid)) {
+      bids.push(bid);
+    } else {
+      utils.logError(BIDDER_CODE + ': server returns invalid response');
+    }
 
     return bids;
   } catch (e) {

From 4d30ae80d2904377299677c5e612a3aac2ed2bf4 Mon Sep 17 00:00:00 2001
From: Mario Ortas <mario.ortas@outlook.com>
Date: Mon, 2 Aug 2021 18:44:49 +0200
Subject: [PATCH 22/22] fix failing test

---
 test/spec/modules/vidoomyBidAdapter_spec.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/spec/modules/vidoomyBidAdapter_spec.js b/test/spec/modules/vidoomyBidAdapter_spec.js
index 7861262babe..37452914e79 100644
--- a/test/spec/modules/vidoomyBidAdapter_spec.js
+++ b/test/spec/modules/vidoomyBidAdapter_spec.js
@@ -1,6 +1,7 @@
 import { expect } from 'chai';
 import { spec } from 'modules/vidoomyBidAdapter.js';
 import { newBidder } from 'src/adapters/bidderFactory.js';
+import { INSTREAM } from '../../../src/video';
 
 const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
 
@@ -44,7 +45,7 @@ describe('vidoomyBidAdapter', function() {
     it('should return false when mediaType is video with INSTREAM context and lacks playerSize property', function () {
       bid.params.mediaTypes = {
         video: {
-          context: 'INSTREAM'
+          context: INSTREAM
         }
       }
       expect(spec.isBidRequestValid(bid)).to.equal(false);