Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vidoomy Bid Adapter: add new bid adapter #7178

Merged
merged 24 commits into from
Aug 3, 2021
Merged

Conversation

mario-orle
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Added a new bidder adapter for Vidoomy.

  • test parameters for validating bids
{
  bidder: 'vidoomy',
  params: {
    id: '123123',
    pid: '123123'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

https://www.vidoomy.com

Sorry, something went wrong.

mario-orle and others added 2 commits July 13, 2021 20:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ChrisHuie ChrisHuie changed the title Add Vidoomy bidder adapter Vidoomy Bid Adapter: add new bid adapter Jul 14, 2021
modules/vidoomyBidAdapter.js Show resolved Hide resolved
modules/vidoomyBidAdapter.js Show resolved Hide resolved
modules/vidoomyBidAdapter.js Outdated Show resolved Hide resolved
modules/vidoomyBidAdapter.js Outdated Show resolved Hide resolved
modules/vidoomyBidAdapter.js Outdated Show resolved Hide resolved
modules/vidoomyBidAdapter.js Outdated Show resolved Hide resolved
@mario-orle
Copy link
Contributor Author

Requested changes done :)

@mario-orle
Copy link
Contributor Author

Changes done

test/spec/modules/vidoomyBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/vidoomyBidAdapter_spec.js Show resolved Hide resolved
modules/vidoomyBidAdapter.js Show resolved Hide resolved

const render = (bid) => {
bid.ad = bid.vastUrl;
var obj = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be helpful in the future to name this object.

queryParams.push(['gdpr', bidderRequest.gdprConsent.gdprApplies]);
queryParams.push(['gdprcs', bidderRequest.gdprConsent.consentString]);
}
queryParams.push(['usp', bidderRequest.uspConsent || '']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given you are using a GET and building this data into the URL request it would help to avoid unnecessary characters by not including 'usp' or 'l' if they are empty strings

@ncolletti ncolletti merged commit 51f4f48 into prebid:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants