-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vidoomy Bid Adapter: add new bid adapter #7178
Conversation
Requested changes done :) |
Changes done |
|
||
const render = (bid) => { | ||
bid.ad = bid.vastUrl; | ||
var obj = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be helpful in the future to name this object.
queryParams.push(['gdpr', bidderRequest.gdprConsent.gdprApplies]); | ||
queryParams.push(['gdprcs', bidderRequest.gdprConsent.consentString]); | ||
} | ||
queryParams.push(['usp', bidderRequest.uspConsent || '']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given you are using a GET and building this data into the URL request it would help to avoid unnecessary characters by not including 'usp' or 'l' if they are empty strings
Type of change
Description of change
Added a new bidder adapter for Vidoomy.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
https://www.vidoomy.com