Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnet Bid Adapter: adomain change for Prebid 5.x and remove useless parameter #7124

Merged
merged 8 commits into from
Jun 29, 2021

Conversation

rohsu
Copy link
Contributor

@rohsu rohsu commented Jun 29, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

adomain support added

  • test parameters for validating bids
{
  bidder: 'gnet',
  params: {
    'websiteId': '4'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    [email protected]

  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie self-requested a review June 29, 2021 15:37
@ChrisHuie ChrisHuie self-assigned this Jun 29, 2021
@ChrisHuie ChrisHuie merged commit 1f5b03d into prebid:master Jun 29, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
…rameter (prebid#7124)

* Add files via upload

* Add files via upload

* Change params on gnetBidder

* ADJ - Use parseSizesInput to get sizes
ADJ - Check serverResponse object
ADJ - Remove getUserSyncs function

* ADJ - Change prebid endpoint

* ADJ - Change endpoint on test

* GnetBidAdapter update for Prebid 5.x

Co-authored-by: Roberto Hsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants