Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vrtcal Bid Adapter: add adomain and make 5.0 compliant #7106

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Vrtcal Bid Adapter: add adomain and make 5.0 compliant #7106

merged 4 commits into from
Jun 29, 2021

Conversation

vrtcal-dev
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

adomain support added to last master Vrtcal .js adapter

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie
Copy link
Collaborator

@vrtcal-dev can you please also add back the unit test file for this pr 🙏

@ChrisHuie ChrisHuie self-requested a review June 27, 2021 11:09
@ChrisHuie ChrisHuie self-assigned this Jun 27, 2021
@vrtcal-dev
Copy link
Contributor Author

@vrtcal-dev can you please also add back the unit test file for this pr

Thanks Chris. The unit test file has be reinstated.

@ChrisHuie ChrisHuie changed the title Added Vrtcal 5.0 compat bid adapter /w adomain support Vrtcal Bid Adapter: add adomain and make 5.0 compliant Jun 29, 2021
@ChrisHuie ChrisHuie self-requested a review June 29, 2021 12:43
@ChrisHuie
Copy link
Collaborator

@vrtcal-dev looks like there are a few lint errors if you could fix those too please

@ChrisHuie
Copy link
Collaborator

Fixed the linting errors to make sure this gets into this week's release

@ChrisHuie ChrisHuie merged commit 28d3316 into prebid:master Jun 29, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* Added 5.0 compat bid adapter /w adomain support

* Unit test file reinstated

* fix lint errors

* lint error

Co-authored-by: Chris Huie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants