GUMGUM Bid Adapter: Add GPID for TTD #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2021 14:31
|
Not sure why those unit tests are failing, I did not edit ParrableId's code. :( |
|
@estavillo Kicked off the tests again. There are a few flaky tests we are currently trying to unwind |
ChrisHuie
changed the title
|
@estavillo can you please add some unit test coverage for this pr please too |
|
@ChrisHuie a unit test was added in; plz let us know if this is sufficient to proceed |
|
Looks good to me |
ChrisHuie
approved these changes
Jun 4, 2021
patmmccann
reviewed
Aug 12, 2021
| const req = { ...bidRequests[0], ortb2Imp: { ext: { data: { adserver: { name: 'test', adslot: 123456 } } } } } | ||
| const bidRequest = spec.buildRequests([req])[0]; | ||
| expect(bidRequest).to.have.property('gpid'); | ||
| expect(bidRequest.gpid).to.equal(123456); |
There was a problem hiding this comment.
this will always be a string
patmmccann
reviewed
Aug 12, 2021
| @@ -318,6 +325,7 @@ function buildRequests (validBidRequests, bidderRequest) { | |||
| sizes, | |||
| url: BID_ENDPOINT, | |||
| method: 'GET', | |||
| gpid: gpid, | |||
There was a problem hiding this comment.
unless you put something in data., as you have data.pi above, or data.fp, it doesn't appear to flow through to your endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add gpid from bid request