Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBJS Core: Add allowSendAllBidsTargetingKeys to targetingControls #6822

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2021

Type of change

Feature

Description of change

Allows a publisher to limit the number 'sendAllBids' keys sent to the adServer. For example hb_bidder_rubicon is one of the more redudant keys we would like to stop sending but we still need hb_bidder key sent. This would similar to the targetingControl option, allowTargetingKeys.

Sample Config:
Example will not send hb_bidder_rubicon

    targetingControls: {
        allowTargetingKeys: ['BIDDER', 'AD_ID', 'PRICE_BUCKET'],
        allowSendAllBidsTargetingKeys: ['PRICE_BUCKET', 'AD_ID']
    }

@patmmccann patmmccann changed the title Feature: Limit send all bid keys PBJS Core: Restrict some keys from being sent for all bidders when sendAllBids is true May 24, 2021
src/targeting.js Outdated Show resolved Hide resolved
src/targeting.js Outdated Show resolved Hide resolved
@ncolletti ncolletti added needs 2nd review Core module updates require two approvals from the core team needs review labels Jun 1, 2021
@ncolletti ncolletti requested a review from robertrmartinez June 1, 2021 17:45
@ChrisHuie ChrisHuie self-requested a review June 8, 2021 16:21
@ChrisHuie ChrisHuie removed needs 2nd review Core module updates require two approvals from the core team needs review labels Jun 8, 2021
@ncolletti ncolletti changed the title PBJS Core: Restrict some keys from being sent for all bidders when sendAllBids is true PBJS Core: Add allowSendAllBidsTargetingKeys to targetingControls Jun 8, 2021
@ncolletti ncolletti merged commit 038a58e into master Jun 8, 2021
@ncolletti ncolletti deleted the feature/allowSendAllTargetingKeys branch June 8, 2021 20:29
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants