Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integral Ad Science RTD module: initial release #6816

Merged
merged 10 commits into from
Jun 8, 2021

Conversation

raguilar-ias
Copy link
Contributor

@raguilar-ias raguilar-ias commented May 23, 2021

…model

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@patmmccann patmmccann changed the title PREP-192 Update Prebid.js PET adapter to operate as a real time data … Integral Ad Science RTD module: initial release May 23, 2021
@patmmccann
Copy link
Collaborator

patmmccann commented May 23, 2021

Please make sure to commit to submodules.json

Also, this doesn't ever call an endpoint and it mentions the ias bidder, which is being imminently deprecated for not bidding.

@patmmccann
Copy link
Collaborator

@raguilar-ias have you had a chance to add a doc repo pr?

@patmmccann
Copy link
Collaborator

@raguilar-ias we need the docs pr today, just commit your MD file to the right place in the other repo

@patmmccann patmmccann requested a review from mmoschovas June 8, 2021 12:18
@patmmccann
Copy link
Collaborator

Docs PR is: prebid/prebid.github.io#3017

Copy link
Contributor

@mmoschovas mmoschovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raguilar-ias thanks for making this change. LGTM

@patmmccann patmmccann merged commit 86e86d7 into prebid:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants