Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovrn and Sharethrough Bid Adapters: support for advertiserDomains #6764

Merged
merged 28 commits into from
May 14, 2021
Merged

Sovrn and Sharethrough Bid Adapters: support for advertiserDomains #6764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c2f2046
Update eids.js
patmmccann Mar 25, 2021
c422dc9
Update eids_spec.js
patmmccann Mar 25, 2021
ec752ee
Update eids.js
patmmccann Mar 25, 2021
ea44e21
Update pubmaticBidAdapter_spec.js
patmmccann Mar 25, 2021
d44f298
Update eids.js
patmmccann Mar 25, 2021
10efcdd
Update eids_spec.js
patmmccann Mar 25, 2021
78fb35f
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
5c082a1
Update rubiconBidAdapter_spec.js
patmmccann Mar 25, 2021
09741b0
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
f42f6d8
Delete test/spec/adapters directory
patmmccann Mar 25, 2021
35de176
Update userId_spec.js
patmmccann Mar 25, 2021
078473b
Merge pull request #2 from prebid/master
patmmccann Mar 30, 2021
e7b5d01
Merge pull request #3 from prebid/master
patmmccann Apr 6, 2021
3501414
Delete iasBidAdapter.js
patmmccann Apr 14, 2021
7f186df
Merge pull request #5 from prebid/master
patmmccann Apr 19, 2021
a3023ff
Add files via upload
patmmccann Apr 19, 2021
6971384
Update openxBidAdapter.js
patmmccann Apr 27, 2021
7b3b306
Update openxBidAdapter.js
patmmccann Apr 27, 2021
e8f01f7
Merge branch 'prebid:master' into master
patmmccann May 7, 2021
1164c3e
Merge branch 'prebid:master' into master
patmmccann May 13, 2021
a023cd8
Update sovrnBidAdapter.js
patmmccann May 13, 2021
c70fc8b
Update sharethroughBidAdapter.js
patmmccann May 13, 2021
d16194b
Update sharethroughBidAdapter_spec.js
patmmccann May 13, 2021
df40924
Update sovrnBidAdapter_spec.js
patmmccann May 14, 2021
659bf31
Update sovrnBidAdapter_spec.js
patmmccann May 14, 2021
5c251c6
Update sharethroughBidAdapter_spec.js
patmmccann May 14, 2021
7c9a66e
Update sharethroughBidAdapter_spec.js
patmmccann May 14, 2021
d807609
Update sharethroughBidAdapter_spec.js
patmmccann May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/sharethroughBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export const sharethroughAdapterSpec = {
currency: 'USD',
netRevenue: true,
ttl: 360,
meta: { advertiserDomains: creative.creative && creative.creative.adomain ? creative.creative.adomain : [] },
ad: generateAd(body, req)
}];
},
Expand Down
3 changes: 2 additions & 1 deletion modules/sovrnBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ export const spec = {
netRevenue: true,
mediaType: BANNER,
ad: decodeURIComponent(`${sovrnBid.adm}<img src="${sovrnBid.nurl}">`),
ttl: sovrnBid.ext ? (sovrnBid.ext.ttl || 90) : 90
ttl: sovrnBid.ext ? (sovrnBid.ext.ttl || 90) : 90,
meta: { advertiserDomains: sovrnBid && sovrnBid.adomain ? sovrnBid.adomain : [] }
});
});
}
Expand Down
5 changes: 3 additions & 2 deletions test/spec/modules/sharethroughBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ describe('sharethrough adapter spec', function() {

describe('.interpretResponse', function() {
it('returns a correctly parsed out response', function() {
expect(spec.interpretResponse(bidderResponse, prebidRequests[0])[0]).to.include(
expect(spec.interpretResponse(bidderResponse, prebidRequests[0])[0]).to.deep.include(
{
width: 1,
height: 1,
Expand All @@ -482,7 +482,8 @@ describe('sharethrough adapter spec', function() {
dealId: 'aDealId',
currency: 'USD',
netRevenue: true,
ttl: 360
ttl: 360,
meta: { advertiserDomains: [] }
});
});

Expand Down
12 changes: 8 additions & 4 deletions test/spec/modules/sovrnBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ describe('sovrnBidAdapter', function() {
'netRevenue': true,
'mediaType': 'banner',
'ad': decodeURIComponent(`<!-- Creative --><img src=<!-- NURL -->>`),
'ttl': 60000
'ttl': 60000,
'meta': { advertiserDomains: [] }
}];

let result = spec.interpretResponse(response);
Expand All @@ -407,7 +408,8 @@ describe('sovrnBidAdapter', function() {
'netRevenue': true,
'mediaType': 'banner',
'ad': decodeURIComponent(`<!-- Creative --><img src="<!-- NURL -->">`),
'ttl': 90
'ttl': 90,
'meta': { advertiserDomains: [] }
}];

let result = spec.interpretResponse(response);
Expand All @@ -428,7 +430,8 @@ describe('sovrnBidAdapter', function() {
'netRevenue': true,
'mediaType': 'banner',
'ad': decodeURIComponent(`<!-- Creative --><img src="<!-- NURL -->">`),
'ttl': 90
'ttl': 90,
'meta': { advertiserDomains: [] }
}];

let result = spec.interpretResponse(response);
Expand All @@ -449,7 +452,8 @@ describe('sovrnBidAdapter', function() {
'netRevenue': true,
'mediaType': 'banner',
'ad': decodeURIComponent(`<!-- Creative --><img src="<!-- NURL -->">`),
'ttl': 480
'ttl': 480,
'meta': { advertiserDomains: [] }
}];

let result = spec.interpretResponse(response);
Expand Down