Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteo Bid Adapter: add comment to explain how to remove dependency on RSA validation lib #6747

Merged
merged 1 commit into from
May 19, 2021

Conversation

leonardlabat
Copy link
Contributor

  • Code style update (formatting, local variables)

Description of change

This was asked by @patmmccann.
The goal is to explain for a publisher which won't use our fastbid feature, how to remove the dependency on the RSA validation lib (and thus reduce the generated bundle file).

@ChrisHuie ChrisHuie changed the title [criteo] Added comment to explain how to remove dependency on RSA validation lib Criteo Bid Adapter: add comment to explain how to remove dependency on RSA validation lib May 12, 2021
@ChrisHuie
Copy link
Collaborator

@leonardlabat it looks like this pr may have been pulled last week when we had a rogue IE character and some a few other tests we had to clean up. Pulling recent commits should fix errors on CircleCI

@leonardlabat
Copy link
Contributor Author

Hello @ChrisHuie

I've created my commit based on prebid-5.0 branch (as my change targets PB5 version). And it seems that prebid-5.0 has not been updated since 8 days. So I guess, it may have not the changes you mentionned here.
So, I'm not sure what I should do 🤔

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented May 12, 2021

@leonardlabat Sorry. I missed this was on the 5.0 branch! Ignore what I just said. lol.
Yeah. I haven't done anything on the 5.0 branch this week or last week so not too sure on these test failures. I will dig into recent 5.0 commits to see if there are any flaky tests I run into.

@patmmccann
Copy link
Collaborator

@leonardlabat this is extremely helpful, thank you! Would it be possible to make it a build time flag, similar to #6016 ?

@patmmccann patmmccann self-requested a review May 12, 2021 13:54
@patmmccann patmmccann self-assigned this May 12, 2021
@allanjun
Copy link
Collaborator

hi @patmmccann we are actually struggling to make it work on webpack. We have also seen related discussions on #6079 and #6361 which cover similar needs, we can certainly revisit this once these two discussions are solved, would that work ?

@patmmccann
Copy link
Collaborator

yes, good to know, ty

@patmmccann patmmccann merged commit 540d931 into prebid:prebid-5.0 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants