VIS.X: add instream video support

[mk0x9]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Added instream video support to the adapter.

• A link to a PR on the docs repo: VIS.X: update docs prebid.github.io#2924

[Fawke]

Hi @mk0x9,

Thanks for the PR. The change looks good overall, I had a doubt which I mentioned as a line comment.

Also I would like to test the response coming back, but when I tried using your instream video params (mentioned in the md file), I was getting a CORS error. Can you provide me with some test params which works?

[Fawke]

Is there any reason to not read these values from mediaTypes.video ?

[rrelict]

Hi @Fawke,

We placed them not in mediaTypes.video because these parameters are not mentioned in the doc: https://docs.prebid.org/dev-docs/adunit-reference.html#adunitmediatypesvideo

Should we move them to mediaTypes.video?

[patmmccann]

See #5237 (comment)

[patmmccann]

We weren't aware that page was out of date, will fix today, thank you!

[mk0x9]

@Fawke, can you please provide details how to reproduce CORS error? Or copy request as curl command from chrome devtools? It shouldn't throw a CORS violation, thanks. As for Open RTB params I'll move them to the mediaTypes, thanks for pointing this out.

[mk0x9]

Also there is test page on codepen: https://codepen.io/mk9/pen/XWpGGPa

[mk0x9]

I had updated adapter, docs & codepen: video params has been moved from bid.params to mediaTypes.video.

[rrelict]

Hey, can you give us more info about the CORS error?
Our endpoint for header bidding requests returns both CORS-related headers. It can be checked on the Codepen page provided above:

Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: https://cdpn.io

We'd like to determine the problem. If changes are needed in our SSP, we want to schedule them as early as possible.

[patmmccann]

Could be related to #6698

[Fawke]

Hi @mk0x9,

Thanks for making the change and reading the values from mediaTypes.video. I tried again today to get a response from your endpoint, but again got a CORS error.

I tried the params shared in your md file:

{
        code: 'instream-test-div',
        mediaTypes: {
            video: {
                context: 'instream',
                playerSize: [400, 300],
                mimes: ['video/mp4'],
                protocols: [3, 6]
            },
        },
        bids: [
            {
                bidder: 'visx',
                params: {
                    uid: '921068'
                }
            }
        ]
    }

Your codepen also isn't much helpful because the auction gets aborted and I can't see the response.

[Fawke]

With the merge of #6676, the CORS error is gone. But am still not getting any response back with those params.

[rrelict]

@Fawke,
Thank you for solving the CORS error.

With the merge of #6676, the CORS error is gone. But am still not getting any response back with those params.

Does your test environment has CMP or do you emulate the passing of a consent string?
Our SSP operates only in the EU and we require a consent string in all ad requests.

Please find below a request from our adaptor for the configuration that you using. Even if I open this request in my browser it responses with JSON. There are no targetings or restrictions (there is a small chance you will not get a response, please try a few times in a row).

Can you take the consent string from this request and try again?

https://t.visx.net/hb?pt=net&auids=921068&sizes=400x300&r=18623618746253&cur=EUR&wrapperType=Prebid_js&wrapperVersion=4.37.0-pre-14&playerSize=400x300&protocols=3%7C6&mimes=video%2Fmp4&u=https%3A%2F%2Fcodepen.io%2F&gdpr_consent=CPFXhSgPFXhSgAfTyBENBXCsAP_AAH_AAAigHsNf_X__b3_j-_79__t0eY1f9_7_v-0zjhfdt-8N2f_X_L8X_2M7vF36pq4KuR4ku3bBIQdlHOncTUmx6olVrTPsb02Mr7NKJ7Pkmnsbe2dYGH9_n93T-ZKZ7______7__-_________________9X-_-_____997b____wPYa_-v_-3v_H9_37__bo8xq_7_3_f9pnHC-7b94bs_-v-X4v_sZ3eLv1TXwVcjxJdu2CQg7aOdO4mpNj1RKrWmfY3psZX2aUT2fJNPY29s6wMP7_P7un-yUz3______3________________________9_____7_______gAA&gdpr_applies=1

[mk0x9]

https://t.visx.net/hb responds on OPTIONS request with 405 Method Not Allowed, hence the CORS exception. Regarding CMP exception, seems that for some reason CMP hadn't been initialized, I'm not sure why exactly. I had updated codepen with static cmp configuration: https://codepen.io/mk9/pen/XWpGGPa

[patmmccann]

Can you repull master? Some tests were fixed today

[mk0x9]

Merged recent master

[Fawke]

LGTM!

[muuki88]

@mk0x9 This change breaks configurations where display and video outstream is configured.

The workaround is to add a separate adUnit with the same code and only add mediaTypes.banner.

[mk0x9]

@muuki88 there was an issue with multi-format ad units configurations with video+outstream, in that case VIS.X adapter skipped bidding for that ad unit. This was fixed there: #6936

[muuki88]

Thanks for the fast response ❤️ and the fix.