Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBJS Core: canBidderRegisterSync ignoring iframe sync disabled by default #6535

Merged
merged 15 commits into from
Apr 7, 2021
Merged

PBJS Core: canBidderRegisterSync ignoring iframe sync disabled by default #6535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c2f2046
Update eids.js
patmmccann Mar 25, 2021
c422dc9
Update eids_spec.js
patmmccann Mar 25, 2021
ec752ee
Update eids.js
patmmccann Mar 25, 2021
ea44e21
Update pubmaticBidAdapter_spec.js
patmmccann Mar 25, 2021
d44f298
Update eids.js
patmmccann Mar 25, 2021
10efcdd
Update eids_spec.js
patmmccann Mar 25, 2021
78fb35f
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
5c082a1
Update rubiconBidAdapter_spec.js
patmmccann Mar 25, 2021
09741b0
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
f42f6d8
Delete test/spec/adapters directory
patmmccann Mar 25, 2021
35de176
Update userId_spec.js
patmmccann Mar 25, 2021
078473b
Merge pull request #2 from prebid/master
patmmccann Mar 30, 2021
e7b5d01
Merge pull request #3 from prebid/master
patmmccann Apr 6, 2021
c8397a5
Update userSync.js
patmmccann Apr 6, 2021
d41d06e
Update userSync_spec.js
patmmccann Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/userSync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export function newUserSync(userSyncDependencies) {
}
return checkForFiltering[filterType](biddersToFilter, bidder);
}
return false;
return !permittedPixels[type];
}

/**
Expand Down
18 changes: 18 additions & 0 deletions test/spec/userSync_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,24 @@ describe('user sync', function () {
});
expect(userSync.canBidderRegisterSync('iframe', 'otherTestBidder')).to.equal(false);
});
it('should return false for iframe if there is no iframe filterSettings', function () {
const userSync = newUserSync({
config: {
syncEnabled: true,
filterSettings: {
image: {
bidders: '*',
filter: 'include'
}
},
syncsPerBidder: 5,
syncDelay: 3000,
auctionDelay: 0
}
});

expect(userSync.canBidderRegisterSync('iframe', 'otherTestBidder')).to.equal(false);
});
it('should return true if filter settings does allow it', function () {
const userSync = newUserSync({
config: {
Expand Down