Lemma:set mediaType key value

[lm-abhijit]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[harpere]

LGTM, but needs docs.

[lm-abhijit]

Hello Team,
Above changes, We have just assigned the correct value to the mediaType key into the bid response object. Just change the logic to assign value to that key. Previously we have a check form request object if the user set that type then the media type value set otherwise it set undefined now we have changed logic on basis of response we discover media type and assigned it to the mediaType key inside the bid object. there are not any core changes done to the code.

[harpere]

I was thinking about documenting that you have gdpr support (and any other support that's not documented) here: https://docs.prebid.org/dev-docs/bidders.html

[lm-abhijit]

No sir, We do not have any changes in the document such as.

[harpere]

I see that you support gdpr in both buildRequests() and getUserSyncs(). So why not document that?

[lm-abhijit]

I have to remove the non-supported code. Please review the changes.

[lm-abhijit]

Please review the changes.

[harpere]

You're removing support for GDPR? Does your bid endpoint not support it? in any case, your tests are now failing.

[lm-abhijit]

Yes, right now we have not supported this feature. I have fixed test cases. Please review it.

[lm-abhijit]

Kindly Please review the above changes.

[lm-abhijit]

Hello Team,
Please review the above changes. We have pending integration of a couple of clients since last week.

[lm-abhijit]

You're removing support for GDPR? Does your bid endpoint not support it? in any case, your tests are now failing.

Please review the above changes.

[lm-abhijit]

@harpere can we have the changes reviewed on priority please, this has been pending for a couple of weeks now?
We need to close this ASAP, as we have multiple integrations in the queue.
Let us know if there are any further changes required apart from the suggested one to take this to closure.

[lm-abhijit]

Please kindly review the above changes.

[lm-abhijit]

Hello Team,
Please review the above changes.

[lm-abhijit]

@harpere can we have the changes reviewed on priority please, this has been pending for a couple of weeks now?
We need to close this ASAP, as we have multiple integrations in the queue.
Let us know if there are any further changes required apart from the suggested one to take this to closure.

[harpere]

apologize for the delay - lost track of this ticket, and our slack reminders have gone away.