Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeWheel SSP - Added GDPR to userSync #5969

Merged
merged 1 commit into from
Nov 17, 2020
Merged

FreeWheel SSP - Added GDPR to userSync #5969

merged 1 commit into from
Nov 17, 2020

Conversation

evalenciano
Copy link
Contributor

Type of change

  • Feature

Description of change

Updated FreeWheel's SSP bidder adapter to include GDPR values into the user sync

@robertrmartinez
Copy link
Collaborator

Please fix lint issue:

/home/circleci/Prebid.js/modules/freewheel-sspBidAdapter.js
  411:22  error  Strings must use singlequote  quotes

✖ 1 problem (1 error, 0 warnings)
  1 error, 0 warnings potentially fixable with the `--fix` option.

@evalenciano
Copy link
Contributor Author

Thank you, @robertrmartinez . I've fixed the lint issue. However, circleci still has a failure without displaying any failing test case?

Fawke
Fawke approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke added the LGTM label Nov 17, 2020
@Fawke Fawke merged commit 18afadd into prebid:master Nov 17, 2020
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
@evalenciano @stsepelin
FreeWheel SSP - Added GDPR to userSync (prebid#5969)
81e1ba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evalenciano @robertrmartinez @Fawke