userId module: fix auctionDelay submodules with callbacks

[FilipStamenkovic]

Type of change

• Bugfix

If the userId submodule provides callback, but it never executes that callback, pbjs will get stuck and it won't request bids.

This was detected with identityLink userId submodule in issue #5882.

piece of code:

if (!storage.getCookie('_lr_retry_request')) {
  setRetryCookie();
  utils.logInfo('A 3P retrieval is attempted!');
  ajax(url, callbacks, undefined, { method: 'GET', withCredentials: true });
}

So, for this userId submodule, if there exists _lr_retry_request cookie, it will block prebid from requesting bids, because callbacks are never called.

At first, this seems like a bug in submodule, but further digging down in userId module, I found that that there is setTimeout for auctionDelay, which gets cleared few lines of code afterwards.

Description of change

Proposed solution is to call clearTimeout only after all submodules have executed their callbacks.

[Fawke]

@FilipStamenkovic, Thanks for fixing this, this change looks good. Would it be possible for you to write a unit test for this change? That'll be ideal.

Also, if you can once sync with master and do an npm install, circle-ci tests will start passing.

[FilipStamenkovic]

@Fawke Done. I didn't add any new unit tests, I 'fixed' the old ones.

Old ones were checking that setTimeout function is called, but they were not checking that clearTimeout was not called.
I added checks in tests so that we are sure that clearTimeout was not called.

If you run those tests on master branch they will fail, but if you run them on this branch they will pass.

Please let me know if I need to add anything else.

[Fawke]

LGTM

[Fawke]

Adding @robertrmartinez for second review. Feel free to re-assign if busy.

[FilipStamenkovic]

@Fawke @robertrmartinez Can one of you guys please merge this one?