Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUMGUM: adds support for zone and pubId params #5728

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

susyt
Copy link
Contributor

@susyt susyt commented Sep 10, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adds support for new param fields (zone and pubId) while keeping legacy params still viable
Adds mediatype: video for video product
Small modification for data.bf cc @estavillo

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
PR for prebid.github.io coming soon!

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele
Copy link
Contributor

I suggest to enhance the file gumgumBidAdapter.md too , with some documentation about new parameters and, if any, with test parameters.

@musikele musikele merged commit f1793d3 into prebid:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants