Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Circle CI resource #5725

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Upgrade Circle CI resource #5725

merged 1 commit into from
Sep 16, 2020

Conversation

Fawke
Copy link
Contributor

@Fawke Fawke commented Sep 10, 2020

Type of change

  • CI related changes

Description of change

We were using less resource on our circle ci container (2 cpus and 4GB RAM). I have upgraded it to use (8cpu and 16GB RAM). The pipeline is executing a little bit faster now.

Here's a comparison:

Before:

Screenshot 2020-09-10 at 6 40 08 PM

After:

Screenshot 2020-09-10 at 6 40 57 PM


Since the tests run on Browserstack, the timings are also limited by the resource we've available there, and if two or more Circle CI jobs are running in parallel, the tests will timeout or take longer than usual. That explains one test running ~ 16m even after the upgrade.

NOTE:

This PR does not have any effect on the tests that are currently failing intermittently.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay.

@mkendall07 tagging you for 2nd review (in case we should double-check anything with the circleci support).

@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed on hold labels Sep 15, 2020
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we have a ton of circleCI credits so this should be fine.

@mkendall07 mkendall07 merged commit bce32dc into master Sep 16, 2020
@mkendall07 mkendall07 deleted the ci-resource-upgrade branch September 16, 2020 13:31
zandree-owneriq added a commit to inmar/oiq_Prebid.js that referenced this pull request Sep 16, 2020
zandree-owneriq added a commit to inmar/oiq_Prebid.js that referenced this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants