Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price Floors: Fix bug when caching floor lookup #5673

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

robertrmartinez
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

When a floor is initially looked up, the input request params are saved as an offset so we do not have to run the lookup again.

When we find a cached lookup, we were passing the reference of the object, thus any currency adjustments were overwriting the cached value.

Now we pass back a copy of it.

Co-authored-by: Leif Wickland <[email protected]>
@robertrmartinez robertrmartinez added the needs 2nd review Core module updates require two approvals from the core team label Sep 1, 2020
@jsnellbaker jsnellbaker merged commit bb18807 into master Sep 2, 2020
@robertrmartinez robertrmartinez deleted the floorCopyCurrency branch September 21, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants