Update renderer config #5636
Merged
Update renderer config #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V3 support
Update refererInfo
Fix tabs and spaces
Add ccpa support
Fixed sizes from playerSize Updated md sample
Support aliases
Update spec
Aniview Bid Adapter: Added the new alias
Aniview Bid Adapter: Added the new configs for the renderer
|
@itaynave |
Aniview Bid Adapter: Added unit tests for the renderer
|
hey @itaynave, you have merge conflicts that you need to resolve first (there were changes to aniviewBidAdapter that were merged in the meantime), you need to pull (--rebase) from master branch. Follow the instructions in |
Fix for the aliases conflict
|
Just did it right now
Thanks
Itay
…On Wed, Aug 26, 2020 at 10:15 AM Aleksa Trajkovic ***@***.***> wrote:
hey @itaynave <https://github.com/itaynave>, you have merge conflicts
that you need to resolve first (there were changes to aniviewBidAdapter
that were merged in the meantime), you need to pull (--rebase) from master
branch. Follow the instructions in Use the command line to resolve
conflicts....:
[image: image]
<https://user-images.githubusercontent.com/12955750/91272807-9cbfd500-e77c-11ea-94b5-6ba344b1546e.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5636 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJERYIFJTKDCM6M4PR4Q4Y3SCSZBHANCNFSM4QFC74ZQ>
.
--
*Itay Nave*
Skype: itay.nave
Phone: +972-544429400
This email message and any attachments thereto are confidential and/or
privileged and/or subject to privacy laws and are intended only for use by
the addressee(s) named above.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renderer config, used for future debugging