Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support to ablida Bid Adapter #5545

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Conversation

bokos
Copy link
Contributor

@bokos bokos commented Jul 28, 2020

Type of change

  • Other

Description of change

Add native support to ablida bid adapter

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 16, 2020
@stale stale bot closed this Aug 23, 2020
@bokos
Copy link
Contributor Author

bokos commented Aug 31, 2020

@jsnellbaker Can you reopen the PR? Is there an issue?

@jsnellbaker jsnellbaker reopened this Aug 31, 2020
@stale stale bot removed the stale label Aug 31, 2020
@jsnellbaker jsnellbaker requested review from jsnellbaker and removed request for afewcc August 31, 2020 12:42
@jsnellbaker jsnellbaker assigned jsnellbaker and unassigned afewcc Aug 31, 2020
@jsnellbaker
Copy link
Collaborator

Hi @bokos

I just reopened the PR. I'll take a look at it today and follow-up.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bokos

I took a look through the updates here and I think they mostly look good.

When I tried the test bid (using the params in the md file), I did notice that the mediaType was banner instead of native. Based on the bid response that came from the endpoint, you'll need to specify this property in the intrepretResponse function yourself, otherwise, Prebid will always assume the incoming bid is a banner.

In addition, you'll want to submit a docs PR to update your bidder file to show you support native. The page to update is here and you'll just need to update the media_types field to banner, native

With these two updates, you should be good to go. Please let me know if you have any questions about the above. Thanks!

@bokos
Copy link
Contributor Author

bokos commented Sep 1, 2020

@jsnellbaker
Thanks for your feedback! I've changed the server response to include mediaType native. That seems to work, hb_format is now "native" instead of "banner".
Docs PR is prebid/prebid.github.io#2164

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the update. LGTM

@jsnellbaker jsnellbaker merged commit 6af92be into prebid:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants