Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inmar bidder adapter #5467

Closed
wants to merge 1 commit into from
Closed

Conversation

zandree-owneriq
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add Inmar bidder adapter

  • test parameters for validating bids
{
  bidder: 'inmar',
  params: {
    pid:"ADb1f40rmo",
    supplyType:"site",
    bidfloor:0.40,
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    [email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@zandree-owneriq
Copy link
Contributor Author

"gulp test" was run locally and everything passed. Error message from CircleCI is:

should set the default bidResponse currency when not specified in OpenRTB

"currency" in interpretResponse is being handled the exact same way that Slimcut, SmileWanted, Richaudience, and Smartadserver adapters handle it, so I'm confused as to how following convention has produced an error. Please advise.

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I see the following problem in firefox console when I test the bidder with hello_world.html

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://prebid.owneriq.net:8443/bidder/pb/bid. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

In Chrome I see that the call is failing.

Is this the intended behaviour?

@musikele
Copy link
Contributor

@zandree-owneriq any news?

@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 1, 2020
@stale stale bot closed this Aug 8, 2020
@zandree-owneriq
Copy link
Contributor Author

There are two things that would be very helpful in implementing our adapter. Firstly, is there documentation on the exact format of the validBidRequests and bidderRequest arguments that are passed in to the buildRequests function? I've been using http://prebid.org/dev-docs/bidder-adaptor.html, but much of the information on that page is vague, incomplete, and occasionally contradictory. Very little of the format is fully specified with name, type, description, and examples, and even that is almost entirely concerning the return data, not the input parameters. Is there more detailed specification of the input parameters for the buildRequests function?

Secondly, how do the IDs retrieved in getUserSyncs get applied to the bid request? I don't see any mention of how to use the user sync data in the buildRequests function.

@musikele
Copy link
Contributor

@zandree-owneriq,
Regarding your first question, There are two main sources of informations, the link you provided and other bidder source modules. In case you need more help, there are a lot of ways to get in touch with the prebid community, all of which are monitored. Here it is the link: https://docs.prebid.org/support/

Regarding the second question: you're probably mixing two things here.
When a new user arrives on the website:

  • prebid is loaded. cookies are empty
  • on the very first auction, only userId that come from one of the userId modules will be present in the object bidRequest.userId. You can have a look at the UserID modules here: https://docs.prebid.org/dev-docs/modules/userId.html
  • after the first bid, the cookie sync process starts. This is needed to sync the various cookies between partners. These cookies are then stored under the domain name of the website as first party.
  • Then, with every subsequent request, the synced userid cookies should be sent to the bidder via cookie
    the process i just outlined may change depending on gdpr, ccpa, custom setups, and much more, but this should be the default. So, I suspect you want to get one of the userId from the user Id modules, not cookies from cookie syncs.

Third: the problem i raised on my previous comments is that your bidder is under a CORS policy that prevents prebid to work. By unblocking the endpoint, debugging any issues would be easier.

@zandree-owneriq zandree-owneriq mentioned this pull request Aug 28, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants