-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inmar bidder adapter #5467
Add Inmar bidder adapter #5467
Conversation
"gulp test" was run locally and everything passed. Error message from CircleCI is: should set the default bidResponse currency when not specified in OpenRTB "currency" in interpretResponse is being handled the exact same way that Slimcut, SmileWanted, Richaudience, and Smartadserver adapters handle it, so I'm confused as to how following convention has produced an error. Please advise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I see the following problem in firefox console when I test the bidder with hello_world.html
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://prebid.owneriq.net:8443/bidder/pb/bid. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).
In Chrome I see that the call is failing.
Is this the intended behaviour?
@zandree-owneriq any news? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There are two things that would be very helpful in implementing our adapter. Firstly, is there documentation on the exact format of the validBidRequests and bidderRequest arguments that are passed in to the buildRequests function? I've been using http://prebid.org/dev-docs/bidder-adaptor.html, but much of the information on that page is vague, incomplete, and occasionally contradictory. Very little of the format is fully specified with name, type, description, and examples, and even that is almost entirely concerning the return data, not the input parameters. Is there more detailed specification of the input parameters for the buildRequests function? Secondly, how do the IDs retrieved in getUserSyncs get applied to the bid request? I don't see any mention of how to use the user sync data in the buildRequests function. |
@zandree-owneriq, Regarding the second question: you're probably mixing two things here.
Third: the problem i raised on my previous comments is that your bidder is under a CORS policy that prevents prebid to work. By unblocking the endpoint, debugging any issues would be easier. |
Type of change
Description of change
Add Inmar bidder adapter
Be sure to test the integration with your adserver using the Hello World sample page.
[email protected]
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Add Inmar bidder adapter prebid.github.io#2118
Other information